lightning-qt

lightning-qt copied to clipboard

Add basic tests

1

We could add some basic tests (like "can the plugin be started ?") and setup a CI (Github actions ?). [Here](https://github.com/lightningd/plugins/blob/master/summary/test_summary.py) is a good basis/example.

darosior

Add PyQt5-sip to requirements.txt

1

Otherwise (on Ubuntu 22.04) loading the plugin fails with: ``` Traceback (most recent call last): File "/home/igor/.lightning/plugins/lightning-qt/lightning-qt.py", line 13, in import sip ModuleNotFoundError: No module named 'sip' ```

icota

Failing "$ lightning-cli install_plugin https://api.github.com/repos/lightningd/plugins/contents/lightning-qt"

6

lightning-cli install_plugin https://api.github.com/repos/lightningd/plugins/contents/lightning-qt { "code": -32600, "message": "Error while processing install_plugin: RPC call failed: method: plugin, payload: {'subcommand': 'start', 'plugin': '/media/trenaz/nvme/lightning/bitcoin/plugins/lightning-qt/forms'}, error: {'code': -32602, 'message': '/media/trenaz/nvme/lightning/bitcoin/plugins/lightning-qt/forms: already registered'}", "traceback": "Traceback...

78bash

### Repro "Receive payments" tab: generate an invoice with a description but no label. The plugin will crash. ### Possible solution Generate a random label, or forbid to set a...

darosior