pgFormatter icon indicating copy to clipboard operation
pgFormatter copied to clipboard

idea: can you support Joe Celko SQL formatting?

Open okbob opened this issue 7 years ago • 5 comments

see http://www.sqlstyle.guide/

okbob avatar Aug 22 '17 06:08 okbob

I will look at what can be applied, thanks for the pointer.

darold avatar Aug 27 '17 14:08 darold

Now that we have --wrap-after support, is this item still desired? I am not a big fan of right-justifying the first keyword on each line, which is what I assume this request is for.

bmomjian avatar May 04 '19 01:05 bmomjian

so 4. 5. 2019 v 3:14 odesílatel Bruce Momjian [email protected] napsal:

Now that we have --wrap-after support, is this item still desired? I am not a big fan of right-justifying the first keyword on each line, which is what I assume this request is for.

Joe Celko's style is one of popular SQL styles - that I prefer, because it is more readable for me, than left-justifyng. I think so this style is good enough like any other - but readability feeling and style preferences are very personal and I cannot to say why I prefer it. I think so Celko's style emphasizes first keyword (SELECT, INSERT, ..), and maybe it is reason why I prefer it. But I accept so it is very subjective - similar why somebody prefer red or blue or green colours.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/darold/pgFormatter/issues/40#issuecomment-489281206, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEFO46QEA3VHWTHAD2Z43DPTTPQ5ANCNFSM4DXYUXNQ .

okbob avatar May 05 '19 17:05 okbob

I'm not a big fan of Joe Celko's style too but it seems that there is enough interest for this formatting. For me this is not a priority at all. I've kept this issue open but frankly I will not implement it until all highest priorities in pgFormatter, pgBadger, pgCluu, Ora2Pg, SquidAnalyzer, SendmailAnalyzer ... will be done. That mean that it is at very low priority and will probably not done by me unless this will be the ultimate issue of pgFormatter.

darold avatar May 06 '19 23:05 darold

I agree with the low prioritization.

bmomjian avatar May 06 '19 23:05 bmomjian