fbRads icon indicating copy to clipboard operation
fbRads copied to clipboard

fbad_create_ad has a problem with campaign_id argument

Open 13bzhang opened this issue 8 years ago • 2 comments

There is a problem with campaign_id in the function fbad_create_ad. In the version available on CRAN, you had campaign_id as an argument. But in the latest GitHub version, you don't. I think it might be because it's deprecated. Anyhow, not having campaign_id as an argument is causing problems. I get an error that says:

Error in missing(campaign_id) : 'missing' can only be used for arguments

I might try to do a fix and make a pull request.

13bzhang avatar Feb 09 '17 06:02 13bzhang

Thanks for #46, I will test and merge soon

daroczig avatar Apr 20 '17 13:04 daroczig

Left a comment at https://github.com/cardcorp/fbRads/pull/46/files#r114410067 but in summary, campaign ID is not a requirement for creating a ad.

bjeavons avatar May 02 '17 19:05 bjeavons