binancer icon indicating copy to clipboard operation
binancer copied to clipboard

Usdm support

Open siegfried opened this issue 3 years ago • 7 comments

This PR is related to #22

siegfried avatar Dec 17 '21 14:12 siegfried

I'm a little hesitant to modify the current code base even through a few of them are reusable. I presume to reuse them some renaming and updates might be necessary, so I think adding some tests at first might be a good idea, in order to not break current behavior. This is a WIP PR, so please feel free to leave any comment. @daroczig

siegfried avatar Dec 17 '21 14:12 siegfried

These functions are using deprecated V1 API. Is there a plan to remove them in favor of V3?

  • binance_ticker_all_prices()
  • binance_ticker_all_books()
  • binance_ticker_24hr()

Also these functions which are fundamental should be migrated easily:

  • binance_ping()
  • binance_time()
  • binance_klines()
  • binance_ticks()
  • binance_trades()
  • binance_depth()
  • binance_exchange_info()

@daroczig

siegfried avatar Dec 17 '21 18:12 siegfried

Or shall we version the functions according to the API?

siegfried avatar Dec 17 '21 18:12 siegfried

On a second thoughts we might have to skip the tests requiring authentication until it is possible to have a shared credential for testing. Even though the timestamp can be input as an argument. different credentials would produce different signatures.

siegfried avatar Dec 17 '21 20:12 siegfried

If you feel I'm heading to the right direction, you can merge this PR. I'll add the missing feature one by one. @daroczig

siegfried avatar Dec 18 '21 00:12 siegfried

May I use packages from tidyverse in this package?

siegfried avatar Dec 18 '21 12:12 siegfried

Now LIMIT orders and MARKET orders work on USDM.

siegfried avatar Dec 20 '21 22:12 siegfried