Axel Viala

Thanks for your time and the early review. Sorry for the late reply. About the general feedback about merging or not, the name etc: From @rgacogne > I added a...

If it's in scope I can also apply this hunk `length` was added in beb9fad506e4782fa3cd5db0c484b66493943d8b ```diff diff --git a/pdns/dnsname.cc b/pdns/dnsname.cc index 4f42350bb..62a843403 100644 --- a/pdns/dnsname.cc +++ b/pdns/dnsname.cc @@ -49,9 +49,8...

No problem even three, totally understand looked at the previous commit it was porcelain edits.

Update: Have some results with `string_view` may need some caution in review. If it's better to contribute it in an other pull request let me know! :) EDIT: re-requested review...

Hi @omoerbeek @rgacogne: small update on this small update tried to simplify with `string_view` the constructors. For the changes/issues about the internals of the function maybe this weekend or in...

For sure, will try to sum them up this afternoon or this weekend, an other possibility but may hurt performance is to search both for `\0` and `\\` explicitly. Suggestion...

Got caught by time and there is a lot of call to theses constructors maybe I can add some test for this case. also keep the constructor over `char *`...

Thanks for review the extra parentheses comes from the clang-tidy suggestion will push a change right now. Changes adressed in d0ffeed

Squashed and rebased on top of master. Note failed in CI after rebase (raw log link failed to check sum-up in actions) https://pipelines.actions.githubusercontent.com/serviceHosts/042df3b5-d696-43c5-83a4-124a3267b26e/_apis/pipelines/1/runs/33593/signedlogcontent/552?urlExpires=2022-09-25T01%3A42%3A52.5525298Z&urlSigningMethod=HMACV1&urlSignature=MD6vg9T14l91rcHCpjxfuZ2B6wXK4MfHVc04JyB%2FDs4%3D

Same did a rebase against master and bump.