LightFace icon indicating copy to clipboard operation
LightFace copied to clipboard

HideButton not hiding the whole button

Open compojoom opened this issue 13 years ago • 3 comments

Using the hideButton function doesn't hide the button, but the text in the button.

I think that the hiddenButton class should be added to the label and not on the input itself.

compojoom avatar Apr 18 '11 19:04 compojoom

I've changed the hideButton function to this:

hideButton: function(title) { if(this.buttons[title]) this.buttons[title].getParent().addClass('hiddenButton'); return this.buttons[title]; } and now it appears that the buttons is properly hidden, but I'm not 100% sure that it doesn't brake something else. :)

compojoom avatar Apr 18 '11 20:04 compojoom

Weird...can you add a test case or link to an example? Possibly at jsfiddle?

SitePenDavidWalsh avatar Apr 18 '11 20:04 SitePenDavidWalsh

There you go: http://jsfiddle.net/compojoom/pu2aN/1/

Hope you don't mind that I've copied your css stylesheet and have added the js resource directly from your page.

Cheers, Daniel

compojoom avatar Apr 18 '11 21:04 compojoom