rawspeed icon indicating copy to clipboard operation
rawspeed copied to clipboard

OM System brand and OM-1 camera support

Open sarunasb opened this issue 2 years ago • 5 comments

Based on kmilos:om-1 branch. using "OM System" instead of just "OM".

New "make", as in "manucfacturer" is OM Digital Solutions (like Olympus Imaging Corp., Olympus Corporation).

New "make", as in "brand" is "OM System", used instead of just "Olympus". Name "OM System" is used on the title page of OM-1 user manual, Exif MakerNote, SD card default directory, in OM Workspace software, by vendors alongside "Olympus", etc.

I tested this branch in darktable (with noise profile and white balance presets) by working on ~2000 .ORF images from OM-1.

sarunasb avatar May 10 '22 18:05 sarunasb

@LebedevRI Why can't this be merged?

sarunasb avatar Jun 01 '22 11:06 sarunasb

Hello, maintainers and developers, please let me know what can be done to get this merged. Thank you.

sarunasb avatar Jul 05 '22 16:07 sarunasb

If I saw this PR earlier, I'd order my OM-1 1-2 months ago :laughing: I'm getting mine next week and can help testing, in case that's part of the blocker, or give a hand at anything else needed to get this merged.

esm7 avatar Jul 07 '22 03:07 esm7

I don't know what's impeding review and merge, but here is a darktable branch based on release 4.0.0: https://github.com/darktable-org/darktable/issues/11258#issuecomment-1179588323

sarunasb avatar Jul 09 '22 18:07 sarunasb

I just built Darktable from this branch and I confirm it is working very well with my first OM-1 images!

esm7 avatar Jul 21 '22 11:07 esm7

Indeed, it looks like the branding has been somehow "officialised", so this PR should probably obsolete mine.

In addition, it looks like you can add OM System OM-5 support by simply copying Olympus E-M5 Mark III. @sarunasb

kmilos avatar Nov 04 '22 15:11 kmilos

Having this included in time for darktable 4.2 would be highly appreciated. Thank you!

sarunasb avatar Nov 07 '22 17:11 sarunasb

Indeed, as far as rawspeed decoding, the newly released OM-5 is identical to Olympus E-M5 MkIII. Verified with sample RAW and DNG files from both cameras. OM-5 added to data/cameras.xml.

sarunasb avatar Nov 09 '22 16:11 sarunasb

So i was going to merge this, but i'm not going to. I'm not sure just how exactly else we can reword the message on https://raw.pixls.us/. NO COLOR CHARTS. Please contribute the same 5-sample set that is currently available there for that camera, but of something else, like daylight landscape. Then i'll merge this.

Wrong issue, that was meant for OM-5, moved to https://github.com/darktable-org/rawspeed/pull/399

LebedevRI avatar Jan 29 '23 02:01 LebedevRI

@sarunasb i am sorry. this should not have taken so long. the PR arrived at an unfortunate time.

I've merged it in 51d9192ef11ff72667e55a72ecfb3596fc8748ab, but looks like PR does not recognize the squash-merge as a successful merge of this pr, so looks like the PR will need to be just closed.

LebedevRI avatar Jan 29 '23 02:01 LebedevRI

@sarunasb thank you for the contribution!

LebedevRI avatar Jan 29 '23 02:01 LebedevRI

@sarunasb thank you for the contribution!

@sarunasb i am sorry. this should not have taken so long. the PR arrived at an unfortunate time.

I've merged it in 51d9192, ...

@LebedevRI Better later than never :) Thank you for your time!

sarunasb avatar Jan 29 '23 21:01 sarunasb