rawspeed icon indicating copy to clipboard operation
rawspeed copied to clipboard

Phase One Quadrant Correction Continuation

Open dim162 opened this issue 5 years ago • 21 comments

In Darktable, darkroom, the phaseone IIQL from the p65+ is cut in 4 equal rectangles with different slight tint & luminosity, the exports too. I don't have the problem with Capture One & Rawtherapee. The problem exist within Dt 2.7 & 2.6.2, in ubuntu studio 18.04, 18.10, 19.04. I put the raw in a dropbox folder. < https://www.dropbox.com/sh/lahqwwd8aahmzb2/AABOqKXcWTIXgCC0YR45cEAza?dl=0 >

dim162 avatar Nov 11 '19 16:11 dim162

Yep, still happens in dt master / rs develop. In essence this is continuation of #118. Please can you contribute that CF028114.iiq to RPU ?

LebedevRI avatar Nov 11 '19 17:11 LebedevRI

RPU? Sorry, I'm not aware. Use the CF028114.iiq as you wish, it is at least the minimum that I can do. I made a noise and a color profile.

dim162 avatar Nov 11 '19 20:11 dim162

Sorry, should have just posted the link - https://raw.pixls.us/

LebedevRI avatar Nov 11 '19 20:11 LebedevRI

Ha! Ok. I posted a full set the 2018-09-21, not the CF028114.iiq which shows clearly the problem. If you need specific image, i can do it.

dim162 avatar Nov 11 '19 20:11 dim162

Yes, please upload that single image to RPU. I'm not sure any of the existing samples show this issue, so it will be good to have one.

LebedevRI avatar Nov 11 '19 20:11 LebedevRI

It's done.

dim162 avatar Nov 11 '19 20:11 dim162

Yep, thanks!

LebedevRI avatar Nov 11 '19 20:11 LebedevRI

I'm impatient! The result with Darktable 3.0 + Gimp 2.10.14 under Ubuntu studio, are so impressive, i can forget the software & just do my stuff

dim162 avatar Nov 11 '19 21:11 dim162

So i've took a look, and there is a lot of Phase One-specific corrections not being done for that file:

  • RawSpeed:correction 0x402 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x404 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x405 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x406 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x407 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x408 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x40b unimplemented - in dcraw, Red+blue flat field
  • RawSpeed:correction 0x410 unimplemented - in dcraw, All-color flat fields
  • RawSpeed:correction 0x413 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x41a unimplemented - in dcraw, whole image Polynomial curve
  • RawSpeed:correction 0x41c unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x41e unimplemented - in dcraw, Quadrant multipliers
  • RawSpeed:correction 0x41f unimplemented - in dcraw, Quadrant linearization
  • RawSpeed:correction 0x420 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x421 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x422 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x423 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x424 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x425 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x426 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x427 unimplemented - unknown, not in dcraw
  • RawSpeed:correction 0x428 unimplemented - unknown, not in dcraw

But even then, if one tries to convert that raw via dcraw itself, all that quadrant-ness is still there, meaning in this case it's one of the unknown corrections.

LebedevRI avatar Nov 12 '19 13:11 LebedevRI

I tried with rawdigger/fastrawviewer (win10) & ufraw, rawtherapee (ubuntu studio), i can't see the pattern.

dim162 avatar Nov 13 '19 08:11 dim162

Thanks for checking, that is an interesting data point.

LebedevRI avatar Nov 22 '19 21:11 LebedevRI

It took me sometimes & now i'm sure at 98%, the quadrant appears when i shoot on card (Lexar, Sandisk, Fuji all 5 different cards) & not when i tethered the Ph1 645DF/P65+ through capture1 (Win10 & Macosx).

dim162 avatar Nov 23 '19 18:11 dim162

I was too confident, the problem stay the same tethered or not. Sorry. Dt 3 is incredible

dim162 avatar Nov 30 '19 14:11 dim162

Is there a problem to solve the bug?

dim162 avatar Jan 29 '20 08:01 dim162

As far as I know, I'm also a P65+ user, the sensor of this digital back is made of 4 smaller sensors, I suppose Capture One correct this. But Also Lightroom and any other raw editing software.

esox13 avatar Mar 10 '21 23:03 esox13

Is it possible to switch to libraw, instead of rawspeed?

dim162 avatar Dec 21 '21 10:12 dim162

I've tested this with rawtherapee, I see the same "cross" as in you example. Even with a manual build of current libraw master, the resulting TIFF is not corrected. Do you have any open-source tool/library where you can reproduce an output that is really corrected?

cytrinox avatar Mar 03 '22 17:03 cytrinox

I've tried with rawtherapee/Art & another QII, i don't have the "cross", even with the first IIQ. I put the new set in dropbox https://www.dropbox.com/sh/lahqwwd8aahmzb2/AABOqKXcWTIXgCC0YR45cEAza?dl=0.

Le jeu. 3 mars 2022 à 18:19, Daniel Vogelbacher @.***> a écrit :

I've tested this with rawtherapee, I see the same "cross" as in you example. Even with a manual build of current libraw master, the resulting TIFF is not corrected. Do you have any open-source tool/library where you can reproduce an output that is really corrected?

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/rawspeed/issues/207#issuecomment-1058287842, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACP3YAE3SJB764XKLWL4EQ3U6DYD3ANCNFSM4JLYB5QA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

dim162 avatar Mar 04 '22 09:03 dim162

As the bug is not corrected in Rawspeed, is it possible to support the PhaseOne P65+ digital back, through LibRaw?

dim162 avatar Jul 14 '22 07:07 dim162

@dim162 Quadrant Correction is implemented in https://github.com/dnglab/dnglab, maybe this is an alternative workflow for you.

cytrinox avatar Jul 14 '22 07:07 cytrinox

Thank you! It is an alternative, but it doubles the space kept by images. I hope that a solution will be integrated inside Dt

dim162 avatar Jul 15 '22 05:07 dim162