darktable icon indicating copy to clipboard operation
darktable copied to clipboard

[FR] Scrollbar at the bottom of the filmstrip in the darkroom.

Open difrkaguilar opened this issue 3 years ago • 23 comments

Is your feature request related to a problem? Please describe. It isn't useful when have to scroll the filmstrip with the mouse every time I'm editing and have to locate an image. Then if the collection is too big with a lot of images, I've to back to lighttable, select the image and back to the darkroom and the filmstrip functionality lost it purpose.

Describe the solution you'd like The left, right panels and the central view can show or hide the scrollbars from the darktable preferences, but there are not any scrollbar option for the filmstrip. It will be great to put an scrollbar too at the bottom of the filmstrip in the darkroom, this scrollbar will be useful to move back and forward between all images in the collection without go back to the lighttable.

Alternatives Even using the Home and End key over the filmstrip to go to the first and last image will be a great addition to the filmstrip.

Additional context Screenshot-20210901131659-2647x1501

difrkaguilar avatar Sep 01 '21 17:09 difrkaguilar

This is essentially a duplicate of last remaining issue of #8847

now the question is whether we should close this one, or close #8847 in favour of this one?

johnny-bit avatar Sep 01 '21 21:09 johnny-bit

@johnny-bit commented on Jun 30 in #8847

I do use mouse on filmstrip with not too small collections and find "centering" of the current image very intuitive and jump very acceptable.

from my standpoint - only scrollbar is actionable.

As all of you talk in #8847 this FR is focused in the scrollbar functionality only, I agree as many of you that this is the most actionable feature, not other. But If you consider #8847 have more info related with the filmstrip in general, you can close this FR in favour of #8847

Anyway here or in #8847 the scrollbar suggestion appear to be the most important feature.

difrkaguilar avatar Sep 01 '21 23:09 difrkaguilar

A lot of respect to everyone contributing to Darktable ! The functionality off all the modules is awesome !

However, as simple end user, I would really need an added scrollbar under the darkroom filmstrip to be able to find a workflow that feels natural and comfortable for me.
If someone could develop this, he would be my hero :)

Spidermarc avatar Sep 07 '21 15:09 Spidermarc

This is a Mock up of the scrollbar, the most simple solution, maybe all you guys have a better solution for this. One addition to the functionality of the scrollbar must be using the scroll mouse as usual and Shift+scroll to speed up the navigation thru images.

Screenshot-20210910221143-2566x307

difrkaguilar avatar Sep 11 '21 02:09 difrkaguilar

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Nov 11 '21 00:11 github-actions[bot]

Very much echoing @Spidermarc's sentiment from above :)

Just getting started with Darktable, and was trying to hunt down whether there was an option for this feature - but it seems it's still on the to-do list. Would very much like to keep this feature somewhere near the top of that - at the moment, it's the single thing that I'm finding most friction with in migrating to Darktable.

In terms of the editing functionality and output IQ - I'm loving it already. Many thanks to all who contribute to the development!

dmcTacc avatar Aug 01 '22 09:08 dmcTacc

Same. This feature would add so much to dt. I looked into it, but my GTK skills are basically non-existent, don't think I can do it myself...

Solarer avatar Aug 01 '22 09:08 Solarer

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar May 25 '23 00:05 github-actions[bot]

Ping.

difrkaguilar avatar May 25 '23 02:05 difrkaguilar

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jul 25 '23 00:07 github-actions[bot]

I would love to see this FR on the list of features to add to darktable for use in the darkroom without having to jump back and forth to the lighttable every time I'm in an editing session, as I explain in the #13107 to jump between images using the filmstrip maintaining the color assessment condition active wile I'm curating images.

difrkaguilar avatar Jul 25 '23 03:07 difrkaguilar

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Sep 25 '23 00:09 github-actions[bot]

Bump

Solarer avatar Sep 25 '23 07:09 Solarer

I fully understand the wish expressed in this FR and I just wanted to give a little context to explain why this wasn't quickly implemented already, as I was briefly considering as part of #15183. While for those who like to enter the darkroom with a large selection and then scroll through the filmstrip, a scrollbar is an obvious addition, for those that usually only have a few images there, adding a scrollbar permanently would take up space that either shrinks the film strip images or the main one. So at the very least, the scrollbar should disappear when it is not needed. But that is a non-trivial problem. Even in the lighttable (un)hiding the scrollbars automatically has the tendency to cause jittering; when you add a scrollbar because the images don't fit, you take away space from the thumbnails, which makes them shrink. But now the smaller thumbnails might fit in the filmstrip, so you don't need the scrollbar anymore so you hide it, growing the thumbnails -> loop. Because the selected image is usually in the middle, you can't even just count the number of thumbnails, because depending on their position they might fit or not. And some people who only use, say, double the number of images that fit on the strip are happy just to scroll and don't want to waste the space.

dterrahe avatar Sep 25 '23 12:09 dterrahe

Thank you for the explanation. This technical complication completely did not occur to me. While i understand the desire for automated elegance, though, as someone who has never entered the 'darkroom' with that few images, this nuance feels like throwing the baby out with the bathwater.

I looked at the other request-number you referenced, and the 'speed scrolling' feature does not help with my use-case. Without having a scrollbar, irrespective of the 'speed' at which the strip is scrolled, it's not possible to quickly see 'where in the progression of pictures' I am. That feature helps with the speed of scrolling, but does not help with orientation within a particular set of images.

As a halfway solution: Would it be possible to just have an options-toggle in the settings for either 'don't show the thumbnail scrollbar in darkroom' or 'always show the thumbnail scrollbar'. To me (and by the sounds of it - a few other users too) - the 'smaller thumbnails' may well be worth the tradeoff of always having the scrollbar present. I realize this is not automatically as elegant as your proposed solution, but could cater to both sets of users.

Alternatively: would perhaps adding some 'buffer factor' in checking the resizing/scrollbar issue make the jitter less problematic? I expect the 'scaling factor' of the thumbnails is somehow automatically calculated when the thumbnail preview window is resized (e.g. by adding the scrollbar). So for example, if adding the scrollbar reduces the thumbnail size by 25%, say if there are 3x as many photos in the strip as what is 'visible' (without the scrollbar), then add the srollbar and resize the thumbnails (and if less than 3x as many - leave as-is) . Then even after resizing, you still have 'more than enough' thumbnails for the scrollbar to be useful.

To give an illustrative example: when i shoot timelapses, I may have 2,000+ images to look at in one go. The filmstrip shows about 17 of them 'without a scrollbar'. We'd need to make the thumbnails pretty tiny to fit them all within one/two/three 'filmstrip widths' to render the scrollbar unnecessary. As soon as I have more than 50 photos in one folder, not having a scrollbar starts becoming an issue.

Apologies for the long post; not meaning to sound ungrateful, in case my suggestions are so obvious that they've already been considered & found lacking. And thanks to everyone who has contributed to making the software into what it is already.

dmcTacc avatar Sep 25 '23 14:09 dmcTacc

not meaning to sound ungrateful, in case my suggestions are so obvious that they've already been considered & found lacking.

Apologies on my side for not being more clear about the intent of my post. I wasn't trying to dismiss your suggestion at all; I truly do see the value. I was just explaining why to me this isn't a "fun" project to work on, namely that its the kind of change that leads to unexpected complications that need fixes later and always draws complaints from some corner or other and I'm tired of complaints about attempts to improve things.

I'd be happy if someone else picked this up, but wanted to make them aware of some of the issues in advance. An option in preferences would be fine by me, but people don't like the proliferation of options in general.

BTW the fact that color assessment gets switched off when leaving the darkroom seems to have been an inspired decision by a dev who isn't involved with dt directly anymore. It was meant to protect people from shooting themselves in the foot. At this point those people can be directed to a separate project that aims to cater to them, so this decision could possibly be revisited if an issue was raised.

dterrahe avatar Sep 25 '23 14:09 dterrahe

so this decision could possibly be revisited if an issue was raised.

I explained about this "problem" in my post #13107 but maybe I am the only person who has this problem. What I think is that if all these icons, grouped in the same location and that each of them affect in one way or another the visualization, that are alerts or guides that entering or leaving the darkroom are maintained, there is no logic that users are going to give themselves a "shot in the foot" What is perceived as an error, if you activate these icons and then when returning to the darkroom, you have to activate one of them as many times as you are evaluating the images and entering and leaving the darkroom.

difrkaguilar avatar Sep 25 '23 20:09 difrkaguilar

Sorry for my English, I'm using Deelp 😔

difrkaguilar avatar Sep 25 '23 20:09 difrkaguilar

@dterrahe

growing the thumbnails -> loop.

We should probably take the space away from the main screen even if it sounds counter intuitive at first:

Let's say you have many images and the scrollbars is visible. The user can now scale center and filmstrip as big as he likes to reach his ideal setup. If a collection has fewer images and the scrollbar is not required, you have additional space available. Rather than scaling the filmstrip up, the space should probably be added to the center view.

That also avoids the loop condition

Solarer avatar Sep 27 '23 17:09 Solarer

That would be better indeed, but not so easy : how to know for sure the height taken by the scrollbar before the widget is rendered ? For the record, there's some code if "classic" lighttable to deal with that (avoid the loop with the show/hide scrollbar) but I remember this part of the coding as a nightmare ;)

AlicVB avatar Sep 27 '23 18:09 AlicVB

better

Only if you like fighting with dirty hacks that tend to backfire later on. But then, yes, definitely better!

I'm still out, in case that wasn't clear.

dterrahe avatar Sep 27 '23 18:09 dterrahe

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Nov 27 '23 00:11 github-actions[bot]

I would like to keep this open

Solarer avatar Mar 18 '24 05:03 Solarer

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar May 18 '24 00:05 github-actions[bot]