darktable icon indicating copy to clipboard operation
darktable copied to clipboard

[feature] default `base curve->preserve colors->luminance` to `none`

Open Germano0 opened this issue 4 years ago • 15 comments

Hello, in mailing list, thread "[darktable-user] Getting machine JPG colours in RAW editing" I was trying to figure out how to get colours very similar as the ones you get in camera JPEG. It turned out that I could achieve that by simply changing darkroom->base curve->preserve colors->luminance to darkroom->base curve->preserve colors->none Since many users may want to just adjust the exposure and few other things, by using the colours already generated by the camera, I think darkroom->base curve->preserve colors->none should be the default choice. If the user wants to "build" his own colors, he can do it with a deep manipulation of the RAW file

Germano0 avatar Dec 27 '20 17:12 Germano0

Support it. It is more logical to have it as it was before (preserve colors = none). It makes results much more comparable to in-camera JPEG, which is the source of camera or producer specific base curves.

ghost avatar Dec 27 '20 17:12 ghost

"The best of both worlds" approach would be to:

  • default to filmic + modern color science for new installs in say 3.6
  • with legacy base-curve indeed default to preserve colors = none.

//edit And maybe add warning for users using legacy that legacy is legacy and offers "less than optimal" color science?

johnny-bit avatar Dec 27 '20 17:12 johnny-bit

You could easily create an auto-applied preset to do this.

kofa73 avatar Dec 27 '20 19:12 kofa73

@kofa73 easy to do, but why should we confuse new users? Base curve module approach is calibrated against camera JPEGs and should generate similar result by default as it was for a long time before 3.0 release. New users are not expected to read long manual or watch videos by @aurelienpierre about dt's specific filmic RGB module.

ghost avatar Dec 28 '20 06:12 ghost

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jan 28 '21 00:01 github-actions[bot]

writing a message to avoid autoclose

Germano0 avatar Apr 17 '22 10:04 Germano0

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar May 26 '23 00:05 github-actions[bot]

I've just finished my quick investigation about why my colors are so dull — and found this issue. This new default makes no sense.

apsheronets avatar Jan 06 '24 18:01 apsheronets

OK, I read other issues about it and finally got it. The developers, in their infinite wisdom, decided that the module with the description "Simulate the in-camera JPEG" should not make the image look like JPEG from camera, cause it's "unnatural". Since the default behavior would not be changed anymore, this issue could be closed.

apsheronets avatar Jan 06 '24 19:01 apsheronets

your appreciation of others efforts to provide you a tool to utilize in your photography "hobby" is noted and commended alongside your monitary donations and good will. wishing you the best as you are deserving.

ptilopteri avatar Jan 06 '24 20:01 ptilopteri

Well I am sorry for being salty about changes that silently ruins someone's workflow. I'm sure the new default solves some problem a peasant like me couldn't even understand (so it wasn't explained anywhere).

apsheronets avatar Jan 07 '24 16:01 apsheronets

I've attached a lua script that implements your desired workflow. Unzip it, drop it in your lua/contrib folder in your darktable configuration folder. Start it using script_manager.

The script checks each time you load in image in darkroom to see if

  • its a raw
  • it's not been edited
  • it's using basecurve
  • preserve colors is not set to none

If all these tests are satisfied, then preserve colors is set to none.

basecurve_jpg_colors.zip

wpferguson avatar Jan 07 '24 21:01 wpferguson

Thank yoU!

apsheronets avatar Jan 12 '24 15:01 apsheronets

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Mar 13 '24 00:03 github-actions[bot]