Grouping of images can add non-selected photos

[wrobell]

Describe the bug

In group mode, when adding images to a group, non-selected photos can be added to a group.

Steps to reproduce

1. Enter group mode
2. Select images a.jpg and a.raw - top level message says that 2 images are selected
3. Press Ctrl-G to group images - group is created as expected
4. Select images b.jpg, b.raw, and b-1.jpg - top level message says that 3 images are selected; note that b-1.jpg is a distinct file on disk.
5. Press Ctrl-G to group images - group of 5 images is created and consists of a.* and b* photos
6. There is one group of images, instead of two

This might happen randomly. Seems more prevalent with hundreds of images in a roll.

Expected behavior

There should be two group of images, not one.

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

distro packaging

darktable version

4.8.1

What OS are you using?

Linux

What is the version of your OS?

ArchLinux

Describe your system?

No response

Are you using OpenCL GPU in darktable?

I dont know

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

[wpferguson]

Can't reproduce on ubuntu 22.04 and current master. I use grouping with thousands of images in a roll and haven't seen this issue.

[wrobell]

My workflow usually involves more steps. Let me try to figure out if the additional steps (or additional images) cause the issue. I hope to provide better description to reproduce the problem within next few days.

[github-actions[bot]]

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

[wrobell]

Sorry for long delay. Here is how I can replicate the problem with 6 images and Darktable 5.0.1.

1. I have 6 images

• dscf7216_0.jpg
• dscf7216.hif
• dscf7216.raf
• dscf7257.hif
• dscf7257.raf
• dscf7258.hif

2. All of them are ungrouped
3. Group HEIF and their corresponding RAF files
4. Select green field images (3 images selected)
5. And group them
6. Select scuba tank images (3 images are selected)
7. And group them

Checking grouped images it seems all 6 images are in the last group:

Checking the database

sqlite> select id, group_id, filename from images where group_id = 39192;
id     group_id  filename
-----  --------  --------------
39192  39192     dscf7216.hif
39193  39192     dscf7216.raf
39194  39192     dscf7216_0.jpg
39195  39192     dscf7257.hif
39196  39192     dscf7257.raf
39197  39192     dscf7258.hif

[spasecookee]

I have this issue as well in darktable 5.0.1-win64.

EDIT: I should also note that it happens when the previous group is not collapsed. If the previous group is collapsed, then this bug does not occur.

[github-actions[bot]]

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

[wpferguson]

I think this might occur because the file naming is similar to how darktable names duplicates.

[github-actions[bot]]

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.