darktable icon indicating copy to clipboard operation
darktable copied to clipboard

[FR] ISO 12464 border config in GUI settings

Open Weissnix4711 opened this issue 1 year ago • 4 comments

Is your feature request related to a problem? Please describe.

Cannot adjust ISO 12464 mode border settings without editing darktablerc. As per the docs:

You can modify the distance from the edge of the center panel to the edge of the image by adjusting the darkroom/ui/iso12464_border entry in the $HOME/.config/darktable/darktablerc file. In the same file you can modify the size of the white border (in percent) by adjusting the darkroom/ui/iso12464_ratio entry.

This is not intuitive if using flatpak. It would be much better to just add darkroom/ui/iso12464_border and darkroom/ui/iso12464_ratio to the settings dialog.

Describe the solution you'd like

https://github.com/darktable-org/darktable/blob/768d772a49276e11babe68951b780742b793abc3/data/darktableconfig.xml.in#L2246

<dtconfig prefs="darkroom" section="general">

Correct me if I am wrong, but this should be all necessary to make the config point appear in the GUI settings?

Weissnix4711 avatar Aug 06 '24 17:08 Weissnix4711

There's a tension between keeping the GUI preferences dialog manageable and making configuration easy even in edge cases for less-commonly modified settings....

ralfbrown avatar Aug 06 '24 18:08 ralfbrown

Fair enough, but I would argue for the iso12464_border setting at least. Perhaps it could be kept seperate from the main settings page and instead have a right click menu like the overexposure indicator, softproof or gamut checking tool?

image

I find the ISO 12646 tool can actually be rather useless on smaller monitors because the image itself is just too small.

Weissnix4711 avatar Aug 06 '24 21:08 Weissnix4711

I agree with Ralf of too many settings can make the GUI too long/confusing, but I really like your proposal of using a right click menu.

gi-man avatar Aug 07 '24 01:08 gi-man

I find the ISO 12646 tool can actually be rather useless on smaller monitors because the image itself is just too small.

There are recommendations for "width of border" if using ISO 12646 assessment though ...

jenshannoschwalm avatar Aug 18 '24 08:08 jenshannoschwalm

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Oct 18 '24 00:10 github-actions[bot]

@Weissnix4711 I added the pop-up window you requested, as I also think it is a useful feature for 2 "hidden" configuration variables and for dialing in settings which are desired.

Image

Please have a look and provide feedback: https://github.com/darktable-org/darktable/pull/18433

da-phil avatar Feb 16 '25 22:02 da-phil