darktable icon indicating copy to clipboard operation
darktable copied to clipboard

Duplicate manager freezes the module groups and deactivates the modules

Open Camhunir opened this issue 1 year ago • 7 comments

Describe the bug

Every other time when creating a duplicate, the option for selecting the module groups is frozen - clicking on the buttons doesn’t change anything. When selecting a module it opens up and I can make changes in the module but they are not reflected in the image.

After a restart everything is back to normal.

Steps to reproduce

happens only from time to time

  1. Darktable - darkroom
  2. make changes to an image
  3. Create duplicate in duplicate manager on left side
  4. Selecting a module group does not change the list of modules for the group
  5. Modules can be operated but changes are not reflected in the image
  6. After restart of darktable behavior as expected

Expected behavior

No response

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.8.0

What OS are you using?

Mac

What is the version of your OS?

MacOS Sonoma

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Camhunir avatar Aug 01 '24 02:08 Camhunir

Cannot reproduce on Ubuntu 22.04 with current master 4.9.0+122~g72c4b1e338. I am currently revising numerous (hundreds of) old edits, so I have been using this workflow very frequently for several months. I never observed the described behavior.

pehar1 avatar Aug 01 '24 07:08 pehar1

Thanks for coming back to me. As it is happening infrequently, I will try to find out what is triggering it and come back.

Camhunir avatar Aug 01 '24 07:08 Camhunir

In pixls there was this thread https://discuss.pixls.us/t/my-favourite-darktable-crash-is-with-duplicate-manager/44614

The relevant parts of the logs seems to be shortened_log.txt

@MStraeten @zisoft see the alignment problem in the log. Are you aware of any architecture changes for M3 cpu for cache architecture?

jenshannoschwalm avatar Aug 08 '24 04:08 jenshannoschwalm

Unfortunately I am not skilled at such deeply low-level CPU stuff, sorry. And I am still on a Mac with Intel architecture, so I cannot help with tests on Apple Silicon here.

Do we have any reproducible steps to test?

zisoft avatar Aug 08 '24 06:08 zisoft

Still cannot reproduce on Linux with current master 4.9.0+242~g70cda5d2c9 and fresh config using the image and sidecars provided in the above mentioned pixls thread. Used the duplicates to work on, created new duplicates via "Duplicate" and/or "Original" from the original images and the duplicates. No freeze.

Do we have any reproducible steps to test?

The best description available is in the original post.

pehar1 avatar Aug 08 '24 07:08 pehar1

The best description available is in the original post.

Cannot reproduce on Intel Mac.

zisoft avatar Aug 08 '24 08:08 zisoft

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Oct 08 '24 00:10 github-actions[bot]

I'm still getting this bug with Darktable 5.0.1 on Mac (15.3.1 on Apple Silicon M2), as described here and https://discuss.pixls.us/t/my-favourite-darktable-crash-is-with-duplicate-manager/44614/26

abulka avatar Mar 12 '25 02:03 abulka

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar May 12 '25 00:05 github-actions[bot]

bump (respectfully).

abulka avatar May 12 '25 02:05 abulka

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jul 12 '25 00:07 github-actions[bot]

It would be a shame to close this issue. Crashing soon after duplicating photos is a serious problem.

abulka avatar Jul 12 '25 03:07 abulka

It would be a shame to close this issue. Crashing soon after duplicating photos is a serious problem.

Sure and it won't be closed. Just out mac devs couldn't reproduce yet ;.)

jenshannoschwalm avatar Jul 12 '25 04:07 jenshannoschwalm

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Sep 12 '25 00:09 github-actions[bot]

Confirmed the bug is still there in version 5.2.1.

Makes it impossible to use the duplicates feature unless I quit and restart Darktable after each duplicate is made.

abulka avatar Sep 12 '25 08:09 abulka

I just tried again and indeed I had one case. I then made 30+ attempts again without problems. So really hard to reproduce.

Makes it impossible to use the duplicates feature unless I quit and restart Darktable after each duplicate is made.

Does that mean you can reproduce 100% ?

zisoft avatar Sep 12 '25 14:09 zisoft

We are talking about running on Silicon Mac, right?

I can reproduce 100% though not always with a known series of steps. It happens within a a minute or two of fiddling with duplication and editing. The time seems to vary.

Notice by the end of this video I'm madly clicking over the module tab groups trying to access the modules but they just light up without actually changing tabs. I'm completely locked out of the modules.

https://github.com/user-attachments/assets/e3889f02-068d-4cdd-9975-94903f558949

abulka avatar Sep 13 '25 02:09 abulka

I suspect that this started happening after I switched to using sigmoid instead of filmic by default. @abulka which tone mapper are you using?

Edit: Not true, I am having the same problem with AGX.

masterpiga avatar Oct 12 '25 17:10 masterpiga

Also, this is not caused by OpenCL, as I could reproduce also without it.

masterpiga avatar Nov 07 '25 07:11 masterpiga

Since I started building from source on my own machine I have not experienced this again. So either it's been fixed between 5.2.1 and HEAD, or it's an artifact of the MacOS build (or I have been extremely lucky, but it's very unlikely since I use duplicates all the time). @abulka @zisoft have you tried building from source?

For the record, I build like this (MacOs Tahoe, M4 Pro):

INSTALL_DIR="${HOME}/Applications/darktable-test"
./packaging/macosx/1_install_hb_dependencies.sh
rm -fr build
./build.sh --prefix "${INSTALL_DIR}" --build-type Release --install

Then I run like this:

exec env \
	GSETTINGS_SCHEMA_DIR="/opt/homebrew/share/glib-2.0/schemas/" \
	"${INSTALL_DIR}/bin/darktable" \
	--configdir <your_config_dir>

masterpiga avatar Nov 11 '25 16:11 masterpiga