[Rotate and perspective] module rotate main image only once in the process of editing

[d2r2]

Describe the bug

Activated [Rotate and perspective] module with applied rotate amount rotate image only once. If you activate/deactivate module in unfold state, the main image does not change.

Steps to reproduce

1. Go to Darkroom mode.
2. Go to [Rotate and perspective] module.
3. Apply some rotation amount (-5 for instance).
4. Then you can click multiple times to deactivate/activate module, to observe the bug.

Expected behavior

The main picture should shange on activate/deactivate [Rotate and perspective] module

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.8.0

What OS are you using?

Linux

What is the version of your OS?

Linux myarch 6.9.6-arch1-1

Describe your system?

System Details Report

---

Report details

• Date generated: 2024-06-25 01:10:46

Hardware Information:

• Hardware Model: HP HP ProBook 450 G8 Notebook PC
• Memory: 32.0 GiB
• Processor: 11th Gen Intel® Core™ i7-1165G7 × 8
• Graphics: Intel® Xe Graphics (TGL GT2)
• Disk Capacity: 2.0 TB

Software Information:

• Firmware Version: T70 Ver. 01.12.00
• OS Name: Arch Linux
• OS Build: rolling
• OS Type: 64-bit
• GNOME Version: 46
• Windowing System: Wayland
• Kernel Version: Linux 6.9.6-arch1-1

Are you using OpenCL GPU in darktable?

No

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

[ralfbrown]

I would have said it's working as designed and showing a preview of the effect while the module is open (similar to how the crop module always shows a cropping frame, whether or not activated), but there is a problem even so - if you collapse the module while it is inactive, reopening it doesn't apply the effect, and re-enabling it shows a crop box (or crops, if still collapsed) without applying rotation/perspective. The cropping appears to match what it would be if the effect were being applied.

[d2r2]

@ralfbrown, BTW, we have some very similiar UI issue, when you left not collapsed [graduated density] module: the line showing gradient direction just disappears and no longer visible, when you return to the module in darkroom mode. Please, look reproduction in screencast. To make this line visible again you need to collapse the module (and maybe even reset it).

[jenshannoschwalm]

@ralfbrown this might be related to the other "riddle" in this module, calculating borders for keep-ratio while rotating only works safely if the module is active, not via shortcuts and alike.

I have tried to understand this, ATM I guess it's related to preview pipe runs, could you have a deeper look?

[jenshannoschwalm]

@d2r2 the [graduated density] module issue maybe looks alike but is something different - codewise.