darktable icon indicating copy to clipboard operation
darktable copied to clipboard

unsupported model warning now only shown once

Open JeanGrng opened this issue 1 year ago • 3 comments

I propose those small changes to fix #16482 . Unsupported model warning should now only been seen once.

JeanGrng avatar Apr 19 '24 21:04 JeanGrng

This doesn't seem to cover the case when you load a different but also unsupported model?

kmilos avatar Apr 19 '24 21:04 kmilos

Yes, this looks a little too aggressive at silencing the warning - it will only show once per run. An intermediate level would be to store the model string instead of using a boolean, and issue the warning if the current image was taken with a different unsupported model than the most recent image (during the current run) to have been from an unsupported model.

ralfbrown avatar Apr 20 '24 02:04 ralfbrown

Yes, you are right. Now the warning should appear only once for each model.

JeanGrng avatar Apr 20 '24 07:04 JeanGrng

This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

github-actions[bot] avatar Jul 01 '24 00:07 github-actions[bot]

@JeanGrng It looks like other priorities are preventing you from completing this PR. Do you still want to complete it, or should we take your code from this PR and add it to darktable ourselves?

victoryforce avatar Jul 01 '24 09:07 victoryforce

@victoryforce Sorry I don’t have the possibility to help you anymore.

JeanGrng avatar Jul 01 '24 12:07 JeanGrng

@JeanGrng Thanks for the contribution! I will add your code to darktable.

victoryforce avatar Jul 02 '24 19:07 victoryforce