darktable icon indicating copy to clipboard operation
darktable copied to clipboard

Highlight recovery module switching randomly to clip highlights instead of inpaint opposed

Open tpinfold opened this issue 10 months ago • 4 comments

Describe the bug

I am using the latest Windows 4.7 +818 weekly build and I have noticed for sometime that the highlights reconstruction module occasionally switches from inpaint opposed to clip highlights. This seems a random event because I went back to the latest image with this problem and checking image history the highlights recovery definitely set to clip highlights itself. Then I made a duplicate image set to original and the module set to inpaint opposed. I then cleared the history of the image at fault and it set the module to inpaint opposed. Going through a series of images it happened on a few randomly with no obvious pattern. The current images were shot on a Olympus TG6, but I believe I have seen in on images from other cameras including my Canon R7. If I see it on any of my other cameras later I will report it here.

Steps to reproduce

This is a random event so even supplying an image may not cause it to reproduce.

Expected behavior

Darktable should use inpaint opposed by default for the highlight recovery module

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

an online forum

darktable version

4.7.0 +818 g7ba9ce722e

What OS are you using?

Windows

What is the version of your OS?

windows 11 home

Describe your system?

No response

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

Nvidia GEFORCE GTX

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

tpinfold avatar Mar 31 '24 22:03 tpinfold

Did you possible copy & paste history or style from an image that doesn't support "inpaint opposed"?

Could you share the xmp at least? (better also the image in question)

jenshannoschwalm avatar Apr 01 '24 06:04 jenshannoschwalm

I've noticed that Clip Highlights seems to be the default now in 4.6.1, whereas I thought it was meant to be Inpaint opposed. When I click reset on the module, it resets to Clip Highlights. I have checked that I don't have any auto applied presets for this module. Is there anything else I should check, or do we have a bug?

europlatus avatar Apr 27 '24 23:04 europlatus

  • europlatus @.***> [04-27-24 19:04]:

I've noticed that Clip Highlights seems to be the default now in 4.6.1, whereas I thought it was meant to be Inpaint opposed. When I click reset on the module, it resets to Clip Highlights. I have checked that I don't have any auto applied presets for this module. Is there anything else I should check, or do we have a bug?

I am using master build 4.7.0+1037~g5fa5735051 and the default is set to "inpaint opposed"

-- (paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri http://en.opensuse.org openSUSE Community Member facebook/ptilopteri Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet oftc

ptilopteri avatar Apr 27 '24 23:04 ptilopteri

"Did you possible copy & paste history or style from an image that doesn't support "inpaint opposed"? Could you share the xmp at least? (better also the image in question)".

Sorry for late reply. I missed seeing the question. I do apply a style which has basic denoising, sharpening, exposure and white balance settings. But this issue seems random and hard to reproduce. Resetting the history on the images that presents clips highlights option usually get rid of the problem. I am not sure if problem persists on the latest 4.7 build. If it reoccurs I will inform you. Thanks

tpinfold avatar Apr 28 '24 02:04 tpinfold

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jun 29 '24 00:06 github-actions[bot]