darktable icon indicating copy to clipboard operation
darktable copied to clipboard

The collection selection does not work correctly

Open Pepa-D750 opened this issue 1 year ago • 6 comments

Describe the bug

I am solving the problem of how many times I used an aperture in the range of 2.8 to 4 with a Tamron 24-70 lens on a Nikon D750 while rating the image with 3 stars and a red mark at the same time. As long as I don't enter the aperture selection, everything filters fine. As soon as I try to add aperture selection nothing is found. Example: collection: Nikon-D750 rating: 3 stars color mark: red lens: Tamron 24-70mm .. aperture: 2.8 -- it doesn't pick anything here

Am I doing something wrong or where is the problem? Thanks for the direction if I'm doing it wrong.

Steps to reproduce

  1. collection: Nikon-D750
  2. rating: 3 stars
  3. color mark: red
  4. lens: Tamron 24-70mm ..
  5. aperture: 2.8 -- it doesn't pick anything here

Expected behavior

No response

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.6.0

What OS are you using?

Linux

What is the version of your OS?

openSUSE Leap 15.5

Describe your system?

No response

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Pepa-D750 avatar Jan 04 '24 19:01 Pepa-D750

I can't reproduce here... Can you check some points :

  1. (to be sure) : with all the filters except aperture, you have image with aperture 2.8 shown, right ?
  2. What if you use only the Aperture filter ?
  3. How do you set the filters ? with the collection module, the filtering module or the top toolbar ?
  4. Can you provide a screenshot with all the filters set ?

Thanks !

AlicVB avatar Jan 04 '24 19:01 AlicVB

Hello, there is probably a problem with the aperture selection. I am attaching screenshots of a selection of several different filters. In this case, I always use the filters on the left side of the screen, see images. I hope this helps you to fix the problem that was already in version 4.4.2. thank you and have a nice day.

Pepa

Good MAX-value-F MIN-value-F Screen-4014

Bed-F2 8- Darktable-version F-all-pictures-27076 F2 8-5 0-bed F19-bed-pictures-27076 F19-only-one Good-F-question mark

Pepa-D750 avatar Jan 05 '24 15:01 Pepa-D750

Hello, there is probably a problem with the aperture selection. I am attaching screenshots of a selection of several different filters. In this case, I always use the filters on the left side of the screen, see images. I hope this helps you to fix the problem that was already in version 4.4.2. I put the pictures on the website because it didn't go through my email. Thank you and have a nice day. Pepa

čt 4. 1. 2024 v 20:57 odesílatel AlicVB @.***> napsal:

I can't reproduce here... Can you check some points :

  1. (to be sure) : with all the filters except aperture, you have image with aperture 2.8 shown, right ?
  2. What if you use only the Aperture filter ?
  3. How do you set the filters ? with the collection module, the filtering module or the top toolbar ?
  4. Can you provide a screenshot with all the filters set ?

Thanks !

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/16031#issuecomment-1877681735, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFDWA2RJPVRFNBZHQPDYWATYM4CT7AVCNFSM6AAAAABBNMFVKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGY4DCNZTGU . You are receiving this because you authored the thread.Message ID: @.***>

Pepa-D750 avatar Jan 05 '24 15:01 Pepa-D750

It is a locale issue and I can reproduce!

In the german locale which I'm using (and @Pepa-D750's locale as well) the decimal separator is a comma. So f/2.8 gets to f/2,8 (see the screenshots above).

zisoft avatar Jan 05 '24 17:01 zisoft

Maybe similar to https://github.com/darktable-org/darktable/issues/16034 a comma seems to be used to split the term there… Please validate that for this case with darktable -d sql and search for the f-stop

MStraeten avatar Jan 05 '24 23:01 MStraeten

In this case it is the locale which needs to be taken into account for the aperture values.

zisoft avatar Jan 06 '24 11:01 zisoft

I don't understand it exactly, according to #16044 the statement is: "For the aperture values, you need to switch the locale similarly to the exposure filter." Where should I switch the locale? Should I change the language in Darktable to English, for example, or do I have to change the language in the entire system - openSUSE? Isn't that a little dodging the issue? Thank you and have a nice day. Joseph

pá 5. 1. 2024 v 18:21 odesílatel Mario Zimmermann @.***> napsal:

It is a locale issue and I can reproduce!

In the german locale (and @Pepa-D750 https://github.com/Pepa-D750 locale as well) the decimal separator is a comma. So f/2.8 gets to f/2,8 (see the screenshots above).

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/16031#issuecomment-1879015034, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFDWA2WFVYDCQDHPGPRXGH3YNAZDPAVCNFSM6AAAAABBNMFVKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGAYTKMBTGQ . You are receiving this because you were mentioned.Message ID: @.***>

Pepa-D750 avatar Jan 16 '24 18:01 Pepa-D750

This was a comment regarding the code in the PR, you as the user doesn't have to change anything. So with this PR already merged in master it should work now.

zisoft avatar Jan 16 '24 18:01 zisoft

So it should work in the next version? Am I correct? Thank you and have a nice day. Joseph

út 16. 1. 2024 v 19:34 odesílatel Mario Zimmermann @.***> napsal:

This was a comment regarding the code in the PR, you as the user doesn't have to change anything. So with this PR already merged in master it should work now.

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/16031#issuecomment-1894306493, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFDWA2SERQWLDYTSFDXU32DYO3B45AVCNFSM6AAAAABBNMFVKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGMYDMNBZGM . You are receiving this because you were mentioned.Message ID: @.***>

Pepa-D750 avatar Jan 16 '24 19:01 Pepa-D750

I have one more question. Would it not be possible when setting the colors using "Datacolor Spyder Checkr" in the color calibration module - to calibrate using the eyedropper - after setting the corners of the table and when calculating the correct values. Make only one press and the tuning between the reading of these values in this module and the adjustment in the exposure module should not be done manually as it is now. Now I press in the calibration module, calculate the values for setting the exposure module. I go to the exposure module and set it there. I return to the calibration module, calculate again and set the new values again in the exposure module, and so sometimes it is necessary to do this more than ten times before the values for adjusting the exposure do not change. This could certainly be done automatically, these are just calculations that can predict the correct value. It seems to me that human activity is somewhat unnecessary here. But maybe there is no other way. What do you think? What is your view on this matter? Thank you and have a nice day. Joseph

út 16. 1. 2024 v 19:34 odesílatel Mario Zimmermann @.***> napsal:

This was a comment regarding the code in the PR, you as the user doesn't have to change anything. So with this PR already merged in master it should work now.

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/issues/16031#issuecomment-1894306493, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFDWA2SERQWLDYTSFDXU32DYO3B45AVCNFSM6AAAAABBNMFVKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGMYDMNBZGM . You are receiving this because you were mentioned.Message ID: @.***>

Pepa-D750 avatar Jan 16 '24 20:01 Pepa-D750

This is out of scope of this so please open a new issue.

zisoft avatar Jan 16 '24 20:01 zisoft