darktable icon indicating copy to clipboard operation
darktable copied to clipboard

export module: Piwigo not keeping accounts server information across restarts.

Open Dero99 opened this issue 2 years ago • 3 comments

Describe the bug

When DT launched, the Storage Options, Target Piwigo, Server lists Piwigo.com as the only known Server. If I add the correct Server URL, this URL is persistent if Target Storage methods are changed, but returns to Piwigo.com if DT is restarted. The correct Piwigo URL is listed in Darktablerc file. Saving the export as a preset lists my URL correctly until DT relaunched, then even the preset lists Piwigo.com This has been an issue since DT4.2, not tested prior.

Steps to reproduce

Launch DT, Select image in library, Export, Select Piwigo in target storage, enter URL and log in info. Sends image correctly. Restart DT, URL has defaulted back to Piwigo.com. storage options

Expected behavior

The URL should be persistent across restarts and accounts dropdown should list all servers previously used.

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.5.0+1377~gca67684661

What OS are you using?

Mac

What is the version of your OS?

macOS Sonoma 14.1.2

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Dero99 avatar Dec 04 '23 17:12 Dero99

This works as expected for me (dt 4.7/linux) i.e. my piwigo host + login details are retained across a restart. It might be a problem with you darktablerc file or perhaps an issue with the password handling backend. In my case this is 'libsecret' and both username and password are stored there.

phrrk avatar Dec 22 '23 15:12 phrrk

For me too, that's a strange issue.

TurboGit avatar Dec 22 '23 15:12 TurboGit

Always bumps back to Piwigo.com with no user account info after restarts of DT.  This on macOS DT versions from 3.6 to current nightly build 4.7.xxx.  I also have a different computer running Ubuntu 22.04.3 LTS with DT nightly Appimage 4.7.xx and also defaults back to Piwigo.com with DT restarts. DOn Dec 22, 2023, at 7:33 AM, Jim Robinson @.***> wrote: This works as expected for me (dt 4.7/linux) i.e. my piwigo host + login details are retained across a restart. It might be a problem with you darktablerc file or perhaps an issue with the password handling backend. In my case this is 'libsecret' and both username and password are stored there.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Dero99 avatar Dec 22 '23 16:12 Dero99

I'm seeing the same issue, also on macOS (v 14.3), DT 4.6.0. darktablerc has the correct piwigo server at plugins/imageio/storage/export/piwigo/server=************* but shows piwigo.com in the storage options dialog against Piwigo each time I restart it. I also get the same running DT 4.6.0 on Ubuntu 22.04.3 LTS on a Parallels VM on macOS

fjb2020 avatar Feb 08 '24 08:02 fjb2020

With PR #16016 Apple Keychain backend for password storage is implemented. This will come with the next version 4.8

zisoft avatar Feb 08 '24 09:02 zisoft

Reopened because I misinterpreted the issue.

zisoft avatar Feb 08 '24 11:02 zisoft

I can reproduce, it is a macOS issue. I have a fix.

zisoft avatar Feb 08 '24 16:02 zisoft

How does this explain that I also have the server credentials not persistent across restarts on Ubuntu 23.10 ? On this system I have installed various recent versions, either by apt, or AppImage or even compiling via source. I deleted the darktablerc between versions. No personal server name is present or password displayed, always showing Piwigo.com. The server name is listed in darktablerc file

Dero99 avatar Feb 08 '24 17:02 Dero99

Your issue was related to macOS and there was indeed a bug.

If there is another thing wrong on Ubuntu you should better open a new issue.

zisoft avatar Feb 08 '24 18:02 zisoft

Following the update from ziosft 'Fix incorrect string for pwstorage' https://github.com/darktable-org/darktable/pull/16270 I installed the nightly build 4.7.0+502~g986da0340c-arm64 - which I beleive includes the fix - but am still seeing the problem.

Therefore I'm afraid this bug is still present for me, and is also present on Linux and Windows platforms as well as macOS.

I've tried running Darktable 4.6 on Ubuntu 22.04, Windows 10 and Windows 11, on both native amd64 hardware and via Parallels virtualisation on Apple hardware.

In every case the behaviour is the same: Enter correct credentials for the Piwigo target storage, login is validated and I am able to see and select a gallery from my Piwigo server, and export images to that gallery. As long as I don't shut Darktable down those credentials persist, but if I close Darktable and re-open then the Piwigo settings I enter disappear and the default piwigo.com server appears.

I note that there is an 'accounts' line with a dropdown 'v' symbol to the right of the dialog - suggesting that more thatn one different Piwigo accounts can be configured. Clicking this dropdown has no affect so I wonder if this is somehow connected to the bug.

Should I raise another bug as suggested by zisoft above? I note that the original bug as raised by Dero99 was not platform specific and they appear to also have the same problem on Ubuntu.

fjb2020 avatar Feb 09 '24 13:02 fjb2020

Did you select the correct pwstorage manager in the settings? It is on the security tab.

For Macs, set it either to "auto" or "apple_keychain". Then restart darktable. If everthing goes ok, you will be asked to give darktable permissions to write to the keychain.

Then try again to login to your piwigo server.

zisoft avatar Feb 09 '24 13:02 zisoft

My bad - I had missed that setting - thank you.

Setting the password storage backend to use to apple_keychain fixes the non-persisting credentials bug in so far as the Piwigo credentials are now retained between restarts.

However, the export process now fails with an error '[imageio_storage_piwigo] could not upload to Piwigo!'

If I change the password storage backend to none again and restart Darktable, so I have to re-enter the Piwigo credentials - then export process works correctly.

I then change password storage backend to apple_keychain and restart Darktable. The Piwigo credentials are retained - and I am able to sucessfully authenticate to Piwigo and select an album.

I then try to export another photo, or re-export an existing photo, and the process fails as above with '[imageio_storage_piwigo] could not upload to Piwigo!'

I've checked this a few times and it consistently works when I have to re-enter the Piwigo credentials manually and fails when they are remembered in the apple_keychain.

fjb2020 avatar Feb 09 '24 15:02 fjb2020

I cannot reproduce. I restart darktable and the piwigo server and credentials are filled in correctly in the export module. It is of course required to hit the 'Login' button first. Then I export images and they all get uploaded to the server.

zisoft avatar Feb 09 '24 17:02 zisoft

Likewise, I have never been able to reproduce this Piwigo storage issue and I'm using Piwigo quite often.

TurboGit avatar Feb 09 '24 17:02 TurboGit

Using Mac 86 nightly, the Apple darktable now remembers Piwigo details. My Ubuntu 4.6 does not. D.On Feb 9, 2024, at 9:13 AM, Pascal Obry @.***> wrote: Likewise, I have never been able to reproduce this Piwigo storage issue and I'm using Piwigo quite often.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Dero99 avatar Feb 09 '24 17:02 Dero99

@zisoft

I set up a new user on my Piwigo server and using those credentials in Darktable the connectionm and upload to Piwigo now works as expected! Thank you for your efforts and help on this.

fjb2020 avatar Feb 09 '24 18:02 fjb2020

My Ubuntu system now remembers the piwigo server. I found that the preference, security was defaulting back to "none" after relaunching darktable. Seemed to be fixed after I set it to libsecret and changed a random lighttable setting. After relaunch, piwigo server info loaded. Changed the lighttable setting back to original and relaunch, piwigo info still there. Now on 4.6.1

Thanks for the help

D

Dero99 avatar Feb 17 '24 19:02 Dero99