darktable icon indicating copy to clipboard operation
darktable copied to clipboard

multiple parametric masks

Open tpapp opened this issue 3 years ago • 9 comments

Is your feature request related to a problem? Please describe.

Occasionally one would like to select a union of various properties that can be described by parametric masks (eg skin color and blue for eyes, nothing else).

Describe the solution you'd like

Multiple parametric masks in a module instance, to be combined under the same rules as drawn elements and parametric masks.

Alternatives

For some transformations, it is possible to work around this problem by using multiple module instances with the parametric mask elements that would form the union above. However, that becomes tedious when information would be lost by a transformation (eg desaturate some colors), or the transformations are nonlinear.

For example, to desaturate everything but skin tones and blue, one would currently desaturate from red to skin tones, then from skin tones to blue, then from blue onwards. This requires 3 module instances, but all that changes is the mask.

Naturally, drawn masks can be a workaround too and are very powerful, but address a different problem.

Additional context

Discussion.

tpapp avatar Nov 04 '21 08:11 tpapp

If I understand your request I fear that this will make the parametric masks UI even more complex. I think we have reached some complexity bound at the moment. All in all, don't hold your breath on this :)

TurboGit avatar Nov 06 '21 10:11 TurboGit

I fear too that this would add too much complexity.

Nilvus avatar Nov 07 '21 09:11 Nilvus

Just an idea. Maybe separating all masks to mask manager and enabling mask centric workflow/view instead of/with module centric would make some edits faster and make less clutter. E.g. when selecting a mask it would show related modules in special module group....

Dannny1 avatar Nov 11 '21 11:11 Dannny1

Yes, making masks first class would help solve this. Specifically, all this would require is making a mask from existing masks and then using it.

tpapp avatar Nov 11 '21 12:11 tpapp

I figured out a workaround with raster masks.

  1. Pick a module that (a) has a no-op mode and (b) comes earlier in the pipeline than the change you want to make (eg exposure with zero correction). Create one instance for each parametric mask you need.

  2. Use each mask in subsequent corresponding instance of the module you want to apply as a raster mask.

tpapp avatar Nov 15 '21 08:11 tpapp

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jan 15 '22 00:01 github-actions[bot]

I will also welcome this functionality. Perhaps another option would be - if customizing the masks is too complex - to have a module similar to color zones or color look up table that are adapted to scene-reffered workflow.

s7habo avatar Jan 18 '22 10:01 s7habo

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Mar 20 '22 00:03 github-actions[bot]

Today I realized too that I need a parametric mask manager. Single parametric mask cannot tackle blond dyed hair overlapping with skin body and model is behind a dark rock - dyed hair and skin look the same and non-dyed hair merge with rock and they both are interleaving curly stands, so hand drawn mask doesn't help a lot.

yaitskov avatar Aug 13 '22 16:08 yaitskov

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Nov 03 '22 00:11 github-actions[bot]

This issue was closed because it has been inactive for 300 days since being marked as stale. Please check if the newest release or nightly build has it fixed. Please, create a new issue if the issue is not fixed.

github-actions[bot] avatar Aug 31 '23 00:08 github-actions[bot]