statuspage icon indicating copy to clipboard operation
statuspage copied to clipboard

'Deploy to Heroku' Button

Open FlorenceWilliamson opened this issue 7 years ago • 10 comments

What do you think of creating a 'Deploy to Heroku' button? That would make the setup on Heroku much more simple. 😎

FlorenceWilliamson avatar May 22 '18 10:05 FlorenceWilliamson

I use Dokku (https://github.com/dokku/dokku) for a lot of my deployments. I'm not opposed to a 'Deploy to Heroku' button, but I've never used the service.

If you want to submit a patch for it, I will gladly accept it. If not, I'll add it to my 'todo pile' and get to it sometime in the next few decades... ;)

darkpixel avatar May 22 '18 16:05 darkpixel

I will try to send a PR next month. If I come across bigger problems I will let you know here so that you can add it to your todo pile. 😅

FlorenceWilliamson avatar May 23 '18 16:05 FlorenceWilliamson

Do you have a logo I should use. My suggested keywords are "python", "django", "status", "statuspage", "open source", "productivity". Do you have other points?

This is an example app.json from Heroku: { "name": "Node.js Sample", "description": "A barebones Node.js app using Express 4", "repository": "https://github.com/heroku/node-js-sample", "logo": "https://node-js-sample.herokuapp.com/node.png", "keywords": ["node", "express", "static"] }

Logo and keywords are optional but I think it cannot hurt to use them? 🤔

FlorenceWilliamson avatar May 24 '18 08:05 FlorenceWilliamson

Nope. I don't have a logo. I never considered the project to be "that big" that it needed one. It was mainly developed so I could use it in-house with a few clients that I supported. When I stopped supporting them about 18 months ago, I stopped updating the project.

...but if there's interest, the next time I get a free moment I will put some work into the project.

darkpixel avatar May 24 '18 15:05 darkpixel

I suppose I could get someone to design a logo for $10 on fiverr...

darkpixel avatar May 24 '18 15:05 darkpixel

I will leave out the logo for now and we just update the app.json when you have one. It is not necessary.

FlorenceWilliamson avatar May 25 '18 12:05 FlorenceWilliamson

Awesome. I merged the PR into the development branch along with a few library updates to use the latest version of Django. Let me know if it fails to fix the problem you were having.

darkpixel avatar May 25 '18 22:05 darkpixel

Awesome! Heroku now tells me:

Your app was successfully deployed.

😀

FlorenceWilliamson avatar May 28 '18 09:05 FlorenceWilliamson

...but does it work?

darkpixel avatar May 28 '18 16:05 darkpixel

No, it does not work. You can follow the link for details.

No module named stronghold.decorators https://a45r436z56z7547467.herokuapp.com/

FlorenceWilliamson avatar May 29 '18 13:05 FlorenceWilliamson