sketchapp-json-flow-types icon indicating copy to clipboard operation
sketchapp-json-flow-types copied to clipboard

Published 20 hours ago • verified publisher icon darknoon

Add test-cases for shadow and inner shadow

Open weaintplastic opened this issue 6 years ago • 4 comments

In order to complete my PR on adding support for innerShadows (https://github.com/darknoon/sketchapp-json-flow-types/pull/8) I've extended the ShapeGroup test case with a shadow and innerShadow definition

weaintplastic avatar Aug 09 '17 09:08 weaintplastic

👋🏻 @darknoon Do you think this is good to go or is there anything missing? Happy to get your feedback.

Roland

weaintplastic avatar Aug 30 '17 07:08 weaintplastic

Hey @darknoon Any chance this could be looked at ? Thanks, Alvin

ghost avatar Aug 30 '17 19:08 ghost

@alvinsight is this blocking you? just a test case, doesn't affect usage of the library.

darknoon avatar Sep 05 '17 05:09 darknoon

Hey, thanks for replying @darknoon It's on @weaintplastic now, but it was blocking him from merging a PR to React Sketchapp, which we're investigating : https://github.com/airbnb/react-sketchapp/pull/160 But it's all merged now ! 🎉

ghost avatar Sep 05 '17 15:09 ghost