django-suit
django-suit copied to clipboard
Add in support for `show_full_result_count` which is new in Django 1.8
Reference: https://docs.djangoproject.com/en/1.8/releases/1.8/#minor-features https://docs.djangoproject.com/en/1.8/ref/contrib/admin/#django.contrib.admin.ModelAdmin.show_full_result_count
Code: https://github.com/django/django/blob/6ff500127a21f5f2104dc77a09dfa73d5f7c94ce/django/contrib/admin/templates/admin/search_form.html
It only requires adding in an if statement in the template and checking the Django version.
+1 @peterfarrell any update here?
@KFoxder The maintainer never responded so I never took the time to put together a PR.
There was never a PR :)
I rarely put in PRs until maintainer at least responds to an issue as I've lost a time to PRs never being reviewed or not in line with unstated project goals.
Me too, but just if the PR is more complicated. In this case if it was just one IF added as in original template I would accept it for sure. It would take a less time to review PR and diff rather than checking submitted links and trying to figure out what changes exactly are necessary. So in this case PR is welcomed!
@peterfarrell @darklow you want to do it? Or I can? just let me know
@KFoxder @darklow I don't have any time in the foreseeable future to make a PR. I defer to either of you.
I would appreciate if one of you could do it, as you already know what the problem is and how to fix it. Thanks.
+1
Looks like this is already fixed in https://github.com/darklow/django-suit/commit/bb33899e9016826335b5b7149aadf973e3f79398
(and available in 0.2.28)