tablecloth icon indicating copy to clipboard operation
tablecloth copied to clipboard

Add Map.filterMap & fixed #151

Open pm5 opened this issue 3 years ago • 4 comments

pm5 avatar Apr 09 '22 07:04 pm5

Thanks! Should be able to get this merged easily enough:

  • needs tests in both rescript and native
  • the .mli files need to match (rescript-build-and-test-9.1.4 is failing as a result)
  • code needs to be formatting (use npm run format I think)

pbiggar avatar Apr 09 '22 12:04 pbiggar

Hello there, fixed the formats and mli and added some tests. Not sure what failing in build and documentations though.

pm5 avatar Apr 16 '22 05:04 pm5

Hello there, fixed the formats and mli and added some tests. Not sure what failing in build and documentations though.

Thanks! To fix the documentation, I think you just need to run make doc

pbiggar avatar Apr 28 '22 09:04 pbiggar

Hello there. Finally had some time to address this :)

pm5 avatar Jun 15 '22 02:06 pm5

My apologies, I should have merged this before splitting the repos apart. We'll need to move this to the other repos

pbiggar avatar Oct 13 '22 13:10 pbiggar