Migrate Twilio stdlib fns to a new Package, include tests there, and abandon/delete the twilio.tests file.

[StachuDotNet]

trafficstars

Original title: "Our Twilio tests are flaky" The mentioned tests were since commented out. Let's bring them back sometime, likely in a totally different form.

---

https://app.circleci.com/pipelines/github/darklang/dark/3539/workflows/486196d7-c7b0-43fa-8145-1c0dc6f1ed59/jobs/37671/tests#failed-test-0

These tests: https://github.com/darklang/dark/blob/main/fsharp-backend/tests/testfiles/twilio.tests

are currently quite flaky, causing many CI builds to fail.

[StachuDotNet]

What are the most important aspects of this test to you, @pbiggar?

All we're really testing now is that we get a 404 back from Twilio, which makes it feel like we just care about getting a response. If that's the case, we can simplify the test a lot.

IMO long-term, we should move Twilio to Dark code, write tests in Dark, and run a real chain of SMSs on some set cadence. (e.g. CRON)

[pbiggar]

tbh, I'd be happy to just comment the test out. We didn't have one in the past and this served its purpose (helping us transition to F#).

[StachuDotNet]

https://github.com/darklang/dark/pull/4222

I'll change this title to "bring back Twilio tests" and abandon it

[StachuDotNet]

I think a better goal would be "migrate Twilio stdlib fns to a new Package, include tests there, and abandon/delete the twilio.tests file." Is that fair?

[pbiggar]

Yes