dark icon indicating copy to clipboard operation
dark copied to clipboard

F# Analysis result couldn't be converted to OCaml type client expects

Open StachuDotNet opened this issue 2 years ago • 5 comments

An error in converting F# runtime types to OCaml RuntimeTypes

https://github.com/darklang/dark/blob/f12d9bd829aaee4ad561a9af2e59173ad36d9c02/fsharp-backend/src/LibExecution/OCamlTypes.fs#L875

was found

So, that conversion fn needs some update

StachuDotNet avatar Jun 11 '22 21:06 StachuDotNet

~deleted bad repro~

StachuDotNet avatar Jun 11 '22 21:06 StachuDotNet

'minimal' repro:

RT.EApply(
  0UL,
  RT.ELambda(0UL, [(0UL, "f")], RT.ENull(0UL)),
  [],
  RT.InPipe 0UL,
  RT.NoRail
)

Actual bug: The conversion code is set up to handle EApply of EFQFnValues, both in and out of pipes, but not ELambdas

StachuDotNet avatar Jun 11 '22 21:06 StachuDotNet

I'm not quite sure how to get to that state in an actual canvas, but should be able to fix regardless.

StachuDotNet avatar Jun 11 '22 22:06 StachuDotNet

For now, decided to not manually code against this, instead focusing on removing OCamlTypes from our code, which will resolve this.

StachuDotNet avatar Jun 23 '22 13:06 StachuDotNet

regardless, will keep issue open until that's done

StachuDotNet avatar Jun 23 '22 13:06 StachuDotNet