redsocks icon indicating copy to clipboard operation
redsocks copied to clipboard

Fix redsocks_evbuffer_readline with libevent 2.1

Open apoikos opened this issue 7 years ago • 3 comments

_EVENT_NUMERIC_VERSION was renamed to EVENT__NUMERIC_VERSION in libevent 2.1. As a result, redsocks_evbuffer_readline would end up using evbuffer_readline(buf), which causes client connections to hang indefinitely.

Switch the check to using LIBEVENT_VERSION_NUMBER instead. LIBEVENT_VERSION_NUMBER has been around since libevent 2.0.3 and redsocks is already using it in other parts of the code.

Fixes #107, #122.

apoikos avatar Mar 29 '18 19:03 apoikos

This change fixed my issue on archlinux with redsocks and libevent 2.1. Works like a charm now

houtmanj avatar Apr 13 '18 11:04 houtmanj

Any chance we can get this in soon?

agherzan avatar Apr 17 '18 10:04 agherzan

I spent some time debugging this problem until I fixed the problem in my local source tree and discovered this issue. Please merge the pull request proposed by @apoikos, otherwise Redsocks is not usable with http-connect.

matlec avatar Nov 19 '18 13:11 matlec