truenas-go-sdk
truenas-go-sdk copied to clipboard
Updated bluefin_original.yaml with unreleased fixes #10747 #10748
I submitted two PRs to fix upstream doc generation issues:
- https://github.com/truenas/middleware/pull/10747
- https://github.com/truenas/middleware/pull/10748
The good news is that they were accepted :) The bad news is that I suspect they won't release them until "catfish" or whatever they call their next release :(
I manually applied the fixes to a VM and generated these docs. However this is of course controversial:
- Technically they may never be in any "bluefin" release, so one could argue they shouldn't be included in
bluefin_original.yaml
- If we do include them, then any further updates to
bluefin_original.yaml
must also come from a patched version (otherwise it'll drop the fixes)
- If we do include them, then any further updates to
- The changes are indeed fixes, and I did them because without them, adding new routes would've required far more manual work than I'm prepared to do
If you are OK to merge these fixes, I pinky swear I'll provide updated (patched) bluefin_original.yaml
files for any new bluefin patch versions.
If you prefer to not include these, we can either have them in a new release name "bluefinupstream", or I can maintain my fork until the next true release comes out, and then try to merge up to you on that release name.