danger-plugin-istanbul-coverage
danger-plugin-istanbul-coverage copied to clipboard
Report file set does not work for "created" or "createdOrModified" groups
Hello , the following config options do not seem to work as expected.
Issue Summary:
- Files are not displayed when using these two options for
"created"and"createdOrModified" - Code coverage report is correctly displayed when using
"all"
Investigation Results:
- possibly
filterForCoveredFilesis failing to return an array of files - seems like file paths are not in sync for files found with
danger.git.modified_filesvs files fromcoverage
My setup:
-
using
"danger-plugin-istanbul-coverage": "^1.6.2", -
Followed the documentation for this setup https://danger.systems/js/plugins/danger-plugin-istanbul-coverage.html
const coverageConfig = {
coveragePath: {
path: path.resolve(
__dirname,
"...customPath/coverage-summary.json"
),
type: "json-summary"
},
reportMode: "warn",
entrySortMethod: "least-coverage",
reportFileSet: "createdOrModified",
numberOfEntries: 20,
threshold: {
statements: 40,
branches: 40,
functions: 40,
lines: 40
}
};
After investigating this further,
I discovered the file paths from coverage-summary.json and danger.git.modified_files do not match when using the public danger github action
I've switched to run danger directly instead of using the github action which "solved" the issue.
this is still seems to be a valid issue with the plugin