Dario Castañé

icon indicating a website link dario.cat icon indicating an email [email protected]

icon company @datadog icon location Barcelona icon location Catalan, pirate, gopher, bofher, trollslayer, tsundokusha, speaker, senior open source library software engineer - Go @DataDog

Results 208 comments of Dario Castañé

verbose logging for agenttracewriter

@mtoffl01 Is this still required/in development?

Unexpected link between spans for HTTP requests uploading files to Amazon S3

Hi @arochadaniel! Thanks for reaching out. Allow me to clarify: Is the attached image showing the upload of 4+ files? As you are pointing out, it looks like these requests...

Unexpected link between spans for HTTP requests uploading files to Amazon S3

@arochadaniel Let me transfer this to `dd-trace-go` repository, and ask the team maintaining our integrations to see how to proceed. Edit: about how the AWS integration creates the span links,...

feat(ddtrace/tracer): transmit knuth sampling rate to backend

@codex review

feat(ddtrace/tracer): transmit knuth sampling rate to backend

Failing tests are flaky and unrelated to the change.

feat(ddtrace/tracer): transmit knuth sampling rate to backend

Closing until getting more feedback from @yuanyuanzhao3

fix(ddtrace): ensure sampling is propagated on OpenTelemetry

@mxderouet This PR wasn't intended to be merged. It was part of an investigation by APM DCS LP. SDK took over and I think the best solution, already in review,...

fix(ddtracer/tracer): retry sendStats on EOF by marking POST idempotent

@lattwood Thanks for the contribution. Allow us to ping the agent team and extra eyes from our guild. This looks good in a quick review, but we want to double...

fix(ddtracer/tracer): retry sendStats on EOF by marking POST idempotent

In the meantime, can you check the test? Thanks! ``` --- FAIL: TestSendStatsNetworkErrorRetry (0.01s) transport_test.go:615: Error Trace: /home/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/transport_test.go:615 Error: Not equal: expected: 2 actual : 3 Test: TestSendStatsNetworkErrorRetry ```

fix(ddtracer/tracer): retry sendStats on EOF by marking POST idempotent

@lattwood Were you able to give it another try? If not, we'll have to plan the required work if deemed.