DJV icon indicating copy to clipboard operation
DJV copied to clipboard

Image Controls Levels Clamped to 0-1

Open Anti-Distinctlyminty opened this issue 3 years ago • 5 comments

In version 2.0.8 the image controls for levels are clamped between 0 and 1. This doesn't work to well if I want to adjust the levels of an HDR image, for example a Z channel and I know I want to map an exact distance to 1.0

Anti-Distinctlyminty avatar Jan 14 '21 16:01 Anti-Distinctlyminty

Hi, sorry about that; how do you think the slider should behave in that case? Like would dragging the slider only go between 0.0-1.0, but you could type larger/smaller numbers into the text entry? Or maybe the slider widget could be replaced with something like a dial that doesn't have a minimum or maximum?

darbyjohnston avatar Jan 15 '21 00:01 darbyjohnston

I think leaving the actual slider widget between 0-1 is fine as long as we can type arbitrary numbers in the field. Also, having a modifier key + left mouse drag to go out of 0-1 bounds would be nice.

Anti-Distinctlyminty avatar Jan 15 '21 09:01 Anti-Distinctlyminty

Actually how about a popup widget on each slider that lets you set the minimum/maximum values, and maybe other options like the increment/decrement value? That way you can see what the range is in addition to being able to change it, and the slider would adapt to that range so you can always use it to adjust the value.

darbyjohnston avatar Jan 16 '21 18:01 darbyjohnston

Aye, that could work. the only potential annoyance is that it's a multi-step process. Click the popup, select the max field, set the value, close, then adjust the slider, vs click + drag slider for adjustments in bounds, and click + alt + drag slider for adjustments out of bounds. I'm probably over-thinking it though, so a popup is most likely just fine. As long as I can adjust it then I'm happy.

Anti-Distinctlyminty avatar Jan 16 '21 23:01 Anti-Distinctlyminty

Maybe a combination of the two would be best; the popup provides a discoverable way to directly enter and see the values, and the keyboard shortcuts provide an "expert" way to quickly adjust the bounds.

darbyjohnston avatar Jan 19 '21 18:01 darbyjohnston