rust-sdk icon indicating copy to clipboard operation
rust-sdk copied to clipboard

Derive Clone for Client

Open c-thiel opened this issue 2 years ago • 6 comments

Fixes: https://github.com/dapr/rust-sdk/issues/91

I had to change some imports to avoid ambiguous name errors I got, probably due to a new rust version. Feel free to remove them if this is not needed.

c-thiel avatar Mar 13 '23 21:03 c-thiel

@c-thiel I have not personally hit the name errors on 1.68 which is the latest stable version. What version did you hit this issue on?

zedgell avatar Mar 18 '23 08:03 zedgell

Also on 1.68. Maybe those also took effect due to some stricter import rules. My VS-Code Rust Analyzer is also complaining. Feel free to remove them. The derive really is much more important :)

c-thiel avatar Mar 29 '23 15:03 c-thiel

@zedgell, I double checked my setup and my build failed due to some workspace settings. I reverted my other changes so that this PR really just contains this one missing line.

c-thiel avatar Apr 01 '23 09:04 c-thiel

@c-thiel @zedgell is the fact those commits are not signed the main blocker of this PR ?

cscetbon avatar Jan 21 '24 14:01 cscetbon

@cscetbon i personally don't have control over this repo or the ability to review PRs. You may ask in the Discord channel

zedgell avatar Feb 14 '24 22:02 zedgell

@c-thiel Hey👋 would you be able to signoff your commits so I can merge?

mikeee avatar Mar 16 '24 15:03 mikeee

Closing as the changes have been usurped.

mikeee avatar Mar 26 '24 17:03 mikeee