quickstarts icon indicating copy to clipboard operation
quickstarts copied to clipboard

Add Jobs quickstart

Open siri-varma opened this issue 7 months ago • 6 comments

Description

Add Quick start guide for Jobs API

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1115

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [X] The quickstart code compiles correctly
  • [X] You've tested new builds of the quickstart if you changed quickstart code
  • [X] You've updated the quickstart's README if necessary
  • [X] If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

siri-varma avatar May 27 '25 22:05 siri-varma

@dapr-java-sdk-reviewers @cicoyle @salaboy @artur-ciocanu This PR is also good to go. Just need approval for the workflows

siri-varma avatar May 28 '25 05:05 siri-varma

@siri-varma I agree. From a (pure) Java point of view this is ready to be merged.

salaboy avatar May 28 '25 06:05 salaboy

/LGTM

salaboy avatar May 28 '25 06:05 salaboy

@alicejgibbons Added the api to receive the triggers as well.

siri-varma avatar May 28 '25 20:05 siri-varma

@alicejgibbons Added the api to receive the triggers as well.

Thanks @siri-varma looks good now. In my comments I had actually meant that we still could have used one service but had the client and the handers in the same app as per Whit's example here: https://github.com/dapr/quickstarts/blob/d1a7f7ca59291a5e744bf9a03b4db4588100d790/jobs/csharp/http/job-service/Program.cs

Anyways, the more i think about it the more im not sure i love the one app solution better since it might be more likely that users will split out the job invocation in actual scenarios. So all this to say is this can be merged once we get 1.15 :)

alicejgibbons avatar Jun 02 '25 10:06 alicejgibbons

@alicejgibbons small request, could you please trigger the build for this PR ? Want to make sure it passes so that we will not have any suprises at the end

siri-varma avatar Jun 02 '25 17:06 siri-varma

@siri-varma were getting there, can you retarget the release:1.16 branch as well since we will also be releasing this with 1.16, TY!

alicejgibbons avatar Aug 07 '25 18:08 alicejgibbons

@siri-varma if you retarget to 1.16 release branch then we can pull in the new Java sdk 1.15.0 version as well since its merged there now then were g2g!

alicejgibbons avatar Aug 15 '25 13:08 alicejgibbons

@alicejgibbons Its done

siri-varma avatar Aug 18 '25 04:08 siri-varma

@siri-varma this comment then its finally done 🙏

alicejgibbons avatar Aug 21 '25 18:08 alicejgibbons

Addressed the comments

siri-varma avatar Aug 25 '25 04:08 siri-varma