Testcontainer example
Description
Added Testcontainer as an example.
Ideally this should be a published package.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [ ] Code compiles correctly
- [ ] Created/updated tests
- [ ] Extended the documentation
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 100.00%. Comparing base (d1bf38a) to head (4ecfcfd).
:warning: Report is 32 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #701 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 6 6
Branches 1 1
=========================================
Hits 6 6
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
If you could sign your commits, that'll pass the DCO check.
Do you think this should be in something more akin to a @dapr/dapr-test package instead of @dapr/dapr?
If you could sign your commits, that'll pass the DCO check.
Do you think this should be in something more akin to a @dapr/dapr-test package instead of @dapr/dapr?
@WhitWaldo Commits are signed-off.
The folder’s package.json’s name is currently “testcontainers”
I think the published package name should be @dapr/testcontainer
If dapr/js-sdk were already setup for npm workspaces (monorepo) then this could be published from there (here), but it isn’t setup that way currently, so I think this should be moved to a new repo: dapr/testcontainer-node
While I don’t think this is entirely out of place in the examples folder, where it is in this branch, it’s not achieving its full potential there. Once published, it can be advertised on the testcontainers contrib section along with the Dapr Testcontainer for Java that is already advertised there:
https://testcontainers.com/modules/dapr/
@joebowbeer I'm sorry this has taken me a while to circle back on. I'd be happy to get another repo spun up for this (I'll get someone to do it after tomorrow's release call) if you don't mind recommitting to it. I'll ping you when it's up.
I'd be happy to get another repo spun up for this
@WhitWaldo Yes, I'd like to see this happen
@WhitWaldo Closing this in favor of https://github.com/dapr/testcontainer-node/pull/1