js-sdk icon indicating copy to clipboard operation
js-sdk copied to clipboard

[WIP] Fix actor remove functionality and add e2e tests for actor state operations

Open shubham1172 opened this issue 2 years ago • 1 comments

Signed-off-by: Shubham Sharma [email protected]

Description

TODO

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation

shubham1172 avatar Jul 06 '22 08:07 shubham1172

Codecov Report

Merging #316 (6cb86a6) into master (8bbfdbd) will decrease coverage by 5.93%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   31.34%   25.41%   -5.94%     
==========================================
  Files          81       73       -8     
  Lines        5896     5808      -88     
  Branches      199      199              
==========================================
- Hits         1848     1476     -372     
- Misses       4008     4328     +320     
+ Partials       40        4      -36     
Impacted Files Coverage Δ
src/actors/runtime/StateProvider.ts 9.52% <0.00%> (-4.77%) :arrow_down:
src/actors/client/ActorProxyBuilder.ts 11.76% <0.00%> (-88.24%) :arrow_down:
src/implementation/Server/HTTPServer/actor.ts 9.52% <0.00%> (-83.34%) :arrow_down:
src/implementation/Server/HTTPServer/HTTPServer.ts 16.21% <0.00%> (-67.57%) :arrow_down:
src/actors/ActorId.ts 33.33% <0.00%> (-66.67%) :arrow_down:
src/implementation/Client/HTTPClient/health.ts 16.66% <0.00%> (-66.67%) :arrow_down:
src/actors/runtime/AbstractActor.ts 13.51% <0.00%> (-62.17%) :arrow_down:
src/actors/runtime/ActorRuntimeConfig.ts 13.33% <0.00%> (-60.00%) :arrow_down:
src/actors/runtime/ActorRuntime.ts 13.51% <0.00%> (-59.46%) :arrow_down:
src/actors/runtime/ActorManager.ts 12.19% <0.00%> (-58.54%) :arrow_down:
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8bbfdbd...6cb86a6. Read the comment docs.

codecov[bot] avatar Jul 06 '22 08:07 codecov[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar Aug 23 '22 11:08 dapr-bot