js-sdk icon indicating copy to clipboard operation
js-sdk copied to clipboard

Support Observability

Open dolencd opened this issue 4 years ago • 6 comments

Describe the proposal

DAPR supports distributed tracing by sending a trace context in the request/response headers. To support this, js-sdk needs to send this trace context, if it's present in the request, in the response headers.

The trace context should also be available outside the library (for example, to the invoker server callback), so it can be used in other operations related to the request.

dolencd avatar Sep 15 '21 06:09 dolencd

I came here as I'm curious about how to hook into logging with Dapr and Node - is that a goal of this project as well?

johnnyreilly avatar Jan 09 '22 06:01 johnnyreilly

Hi @johnnyreilly this is definitely an item we need more work on. What would be your idea on how we can improve Dapr, Node and the logging capabilities?

XavierGeerinck avatar Feb 08 '22 12:02 XavierGeerinck

@XavierGeerinck Do we want to pick this up and brainstorm around logging? Should I start a design proposal?

tanvigour avatar Mar 08 '22 20:03 tanvigour

/assign

tanvigour avatar Mar 10 '22 14:03 tanvigour

The original issue looks similar to #120, but @johnnyreilly's comment is for logging. Should we track this as a separate issue? It will be good to have a logging interface that SDK's consumers can implement (with a default logging option to stdout/stderr).

shubham1172 avatar Mar 21 '22 02:03 shubham1172

Agreed on making this a separate issue

XavierGeerinck avatar Mar 21 '22 11:03 XavierGeerinck