java-sdk
java-sdk copied to clipboard
Update docs regarding changing the protobuf url and skip the cache
Signed-off-by: John Ewart [email protected]
Description
Changed the docs (they had incorrect property names regarding protobuf files) and added skipCache=true
to the wget
tasks because the files are small and it causes unexpected behavior when changing the protobuf URL (in that it keeps using a cached version even after using mvn clean
and git clean
which makes life a bit confusing until you realize they are being cached in $HOME/.m2/repository/.cache
) so that it will always re-download protobuf definitions.
Also moved the base URL to point to master (@artursouza requested it but it seems like a good idea to keep the SDK up-to-date with whatever the latest protobuf definitions are).
Note that this will not re-download the protobuf files on every build, only when they are not already present (i.e if you do a mvn clean
or git clean
to remove target
directories and other auto-generated bits.)
Issue reference
This fixes issue #792
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [NA] Created/updated tests
- [x] Extended the documentation
Codecov Report
Merging #793 (98d86f7) into master (5a2833c) will decrease coverage by
0.39%
. The diff coverage isn/a
.
:exclamation: Current head 98d86f7 differs from pull request most recent head 71f679f. Consider uploading reports for the commit 71f679f to get more accurate results
@@ Coverage Diff @@
## master #793 +/- ##
============================================
- Coverage 76.64% 76.25% -0.40%
+ Complexity 1145 1119 -26
============================================
Files 104 101 -3
Lines 3627 3516 -111
Branches 418 410 -8
============================================
- Hits 2780 2681 -99
+ Misses 639 637 -2
+ Partials 208 198 -10
Impacted Files | Coverage Δ | |
---|---|---|
.../java/io/dapr/client/domain/ConfigurationItem.java | 50.00% <0.00%> (-6.25%) |
:arrow_down: |
...rc/main/java/io/dapr/exceptions/DaprException.java | 70.37% <0.00%> (-3.71%) |
:arrow_down: |
...c/main/java/io/dapr/client/AbstractDaprClient.java | 85.10% <0.00%> (-2.40%) |
:arrow_down: |
...k/src/main/java/io/dapr/client/DaprClientGrpc.java | 90.04% <0.00%> (-0.50%) |
:arrow_down: |
.../src/main/java/io/dapr/springboot/DaprRuntime.java | 0.00% <0.00%> (ø) |
|
...r/client/domain/SubscribeConfigurationRequest.java | 77.77% <0.00%> (ø) |
|
...lient/domain/UnsubscribeConfigurationResponse.java | ||
...client/domain/UnsubscribeConfigurationRequest.java | ||
.../client/domain/SubscribeConfigurationResponse.java | ||
...k/src/main/java/io/dapr/client/DaprClientHttp.java | 87.81% <0.00%> (+0.78%) |
:arrow_up: |
... and 2 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.