java-sdk icon indicating copy to clipboard operation
java-sdk copied to clipboard

Support distributed lock API

Open CrazyHZM opened this issue 3 years ago • 2 comments

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #747

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation

CrazyHZM avatar Jul 25 '22 07:07 CrazyHZM

@CrazyHZM Please fix conflicts in the PR ...

mukundansundar avatar Sep 07 '22 08:09 mukundansundar

Codecov Report

Merging #764 (86a2834) into master (44f80c9) will decrease coverage by 0.51%. The diff coverage is 62.22%.

@@             Coverage Diff              @@
##             master     #764      +/-   ##
============================================
- Coverage     76.25%   75.73%   -0.52%     
- Complexity     1119     1148      +29     
============================================
  Files           101      104       +3     
  Lines          3516     3651     +135     
  Branches        410      427      +17     
============================================
+ Hits           2681     2765      +84     
- Misses          637      670      +33     
- Partials        198      216      +18     
Impacted Files Coverage Δ
.../src/main/java/io/dapr/client/DaprClientProxy.java 75.86% <ø> (ø)
...k/src/main/java/io/dapr/client/DaprClientHttp.java 82.87% <48.00%> (-4.95%) :arrow_down:
...k/src/main/java/io/dapr/client/DaprClientGrpc.java 86.51% <56.00%> (-3.54%) :arrow_down:
...va/io/dapr/client/domain/UnlockResponseStatus.java 76.92% <76.92%> (ø)
...c/main/java/io/dapr/client/AbstractDaprClient.java 85.71% <100.00%> (+0.60%) :arrow_up:
...c/main/java/io/dapr/client/domain/LockRequest.java 100.00% <100.00%> (ø)
...main/java/io/dapr/client/domain/UnlockRequest.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 29 '22 06:09 codecov[bot]

Codecov Report

Merging #764 (2a32004) into master (7593b0e) will decrease coverage by 0.54%. The diff coverage is 62.22%.

@@             Coverage Diff              @@
##             master     #764      +/-   ##
============================================
- Coverage     77.62%   77.07%   -0.55%     
- Complexity     1161     1190      +29     
============================================
  Files           105      108       +3     
  Lines          3647     3782     +135     
  Branches        419      436      +17     
============================================
+ Hits           2831     2915      +84     
- Misses          603      636      +33     
- Partials        213      231      +18     
Impacted Files Coverage Δ
.../src/main/java/io/dapr/client/DaprClientProxy.java 75.86% <ø> (ø)
...k/src/main/java/io/dapr/client/DaprClientHttp.java 82.98% <48.00%> (-4.05%) :arrow_down:
...k/src/main/java/io/dapr/client/DaprClientGrpc.java 87.04% <56.00%> (-3.50%) :arrow_down:
...va/io/dapr/client/domain/UnlockResponseStatus.java 76.92% <76.92%> (ø)
...c/main/java/io/dapr/client/AbstractDaprClient.java 88.00% <100.00%> (+0.50%) :arrow_up:
...c/main/java/io/dapr/client/domain/LockRequest.java 100.00% <100.00%> (ø)
...main/java/io/dapr/client/domain/UnlockRequest.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 30 '22 03:11 codecov[bot]

@mukundansundar @artursouza - Is this ready for review?

msfussell avatar Sep 13 '23 22:09 msfussell

Codecov Report

Patch coverage: 62.22% and project coverage change: -0.44% :warning:

Comparison is base (b442ba4) 76.47% compared to head (a32bc85) 76.04%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #764      +/-   ##
============================================
- Coverage     76.47%   76.04%   -0.44%     
- Complexity     1398     1427      +29     
============================================
  Files           132      135       +3     
  Lines          4264     4399     +135     
  Branches        497      514      +17     
============================================
+ Hits           3261     3345      +84     
- Misses          743      776      +33     
- Partials        260      278      +18     
Files Changed Coverage Δ
...k/src/main/java/io/dapr/client/DaprClientHttp.java 82.88% <48.00%> (-4.01%) :arrow_down:
...k/src/main/java/io/dapr/client/DaprClientGrpc.java 86.10% <56.00%> (-3.03%) :arrow_down:
...va/io/dapr/client/domain/UnlockResponseStatus.java 76.92% <76.92%> (ø)
...c/main/java/io/dapr/client/AbstractDaprClient.java 85.32% <100.00%> (+0.55%) :arrow_up:
...c/main/java/io/dapr/client/domain/LockRequest.java 100.00% <100.00%> (ø)
...main/java/io/dapr/client/domain/UnlockRequest.java 100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 20 '23 23:09 codecov[bot]