java-sdk
java-sdk copied to clipboard
[WIP]Config API : HTTP APIs and Unsubscribe gRPC API changes
Signed-off-by: pravinpushkar [email protected]
Description
Added HTTP API suport for get, subscribe and unsubscribe config APIs Added unsusbcribe gRPC API support Added domain class for subscribe response Added domain classes for unsubscribe request and response
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #698
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [x] Created/updated tests
- [] Extended the documentation
Ping @artursouza @mukundansundar
@artursouza Instead of
subscribeToConfigurationandunsubscribeFromConfigurationshould it just follow the Proto naming and go withsubscribeConfigurationandunsubscribeConfiguration? Thoughts? @pravinpushkar Added comments on refactoring the code.
Renamed all to match proto naming pattern. i.e subscribeConfiguration and unsubscribeConfiguration
@mukundansundar As there is a different issue for array to dict changes for config API tracking the runtime and contrib PR as well, I will submit a different PR for that.
This is open for review and we can remove the do-not-merge lable
I will rebase this PR again when list to map changes are merged with following PR - https://github.com/dapr/java-sdk/pull/769
@artursouza I will submit a new commit with fixes.
@artursouza Updated the commit with suggested changes. There is minor diff in code cov in PR checks.
Codecov Report
Merging #740 (8d305ed) into master (44f80c9) will increase coverage by
0.49%. The diff coverage is87.60%.
@@ Coverage Diff @@
## master #740 +/- ##
============================================
+ Coverage 76.25% 76.75% +0.49%
- Complexity 1119 1146 +27
============================================
Files 101 104 +3
Lines 3516 3626 +110
Branches 410 418 +8
============================================
+ Hits 2681 2783 +102
+ Misses 637 636 -1
- Partials 198 207 +9
| Impacted Files | Coverage Δ | |
|---|---|---|
| .../src/main/java/io/dapr/springboot/DaprRuntime.java | 0.00% <ø> (ø) |
|
| .../java/io/dapr/client/domain/ConfigurationItem.java | 56.25% <0.00%> (+6.25%) |
:arrow_up: |
| ...k/src/main/java/io/dapr/client/DaprClientHttp.java | 87.00% <83.75%> (-0.82%) |
:arrow_down: |
| ...k/src/main/java/io/dapr/client/DaprClientGrpc.java | 90.54% <94.44%> (+0.49%) |
:arrow_up: |
| ...c/main/java/io/dapr/client/AbstractDaprClient.java | 87.50% <100.00%> (+2.39%) |
:arrow_up: |
| .../client/domain/SubscribeConfigurationResponse.java | 100.00% <100.00%> (ø) |
|
| ...client/domain/UnsubscribeConfigurationRequest.java | 100.00% <100.00%> (ø) |
|
| ...lient/domain/UnsubscribeConfigurationResponse.java | 100.00% <100.00%> (ø) |
|
| ...io/dapr/client/domain/GetConfigurationRequest.java | 77.77% <0.00%> (-11.12%) |
:arrow_down: |
| ...r/client/domain/SubscribeConfigurationRequest.java | 77.77% <0.00%> (ø) |
|
| ... and 4 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.