Provide custom grpc/http client for DaprClientBuilder as in #683

[subash89]

Signed-off-by: Subash Gamage [email protected]

Description

This is to Enhance DaprClientBuilder to override gRPC and Http Client. Complete description and reference JIRA can be found at https://github.com/dapr/java-sdk/issues/683

This includes changes in DaprClientBuilder class to accept a managed grpc client as well as ok http client.

Issue reference

https://github.com/dapr/java-sdk/issues/683

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• [ ] Code compiles correctly
• [ ] Created/updated tests
• [ ] Extended the documentation

[subash89]

@artursouza I updated the PR with new changes and reverted the old commit. New change is minimal as I provided a easy way to extend the builder class. Because maintaining a two Builder classes is hard to maintain as code is duplicated. Let me know your thoughts. And I did not touch http builder yet as you said okhttp will go away. Once we have that finalized, I will add capability to override http client as well.

[subash89]

Looks like it didn't like my reverse commit. I followed git checkout git commit --amend --no-edit --signoff git push --force-with-lease @mukundansundar Is it looks good now ? (How to make sure DCO is all set on a given pull request ?)

[mukundansundar]

@subash89 Can you rebase all your commits into a single commit ? Also could you fix the check style violations in the PR?

[subash89]

@mukundansundar If you mean to say squash commits, I cannot squash them into one as I already pushed them to the branch. If not can you suggest how can I do that ? Or I can do a new PR with only this change.

This is my first PR, where to find checkstyle report inorder to fix those.

[subash89]

@artursouza meantime I update the PR, can you pls suggest a way to build this on a mac or some easy way to find out what are the checkstyle violaitons are.

[subash89]

@artursouza Updated the PR. please let me know.

[subash89]

@artursouza any help appreciated.

[mukundansundar]

@artursouza any help appreciated.

@subash89 Can you merge with latest master resolve conflicts and see if you are able to build it with the changes in master?

[subash89]

@mukundansundar main problem I am having is to build this in a mac? [ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (default) on project dapr-sdk-autogen: Error extracting protoc for version 3.13.0: Unsupported platform: protoc-3.13.0-osx-x86_64.exe -> [Help 1]

[mukundansundar]

@mukundansundar main problem I am having is to build this in a mac? [ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (default) on project dapr-sdk-autogen: Error extracting protoc for version 3.13.0: Unsupported platform: protoc-3.13.0-osx-x86_64.exe -> [Help 1]

Does this happen with the latest changes from master too? Because I faced a similar issue with M1 Mac and I had to update some of the dependencies and use Rosetta enabled terminal for it to work.

[subash89]

Yes in master too

[subash89]

Can this be build on a linux box ?

[mukundansundar]

Can this be build on a linux box ?

the build workflow is on a linux runner only

[amuthapriya4]

Please commit the changes for Managed channel to the release branch. With current version it going with default config.

[cicoyle]

@subash89 - mind resolving the conflicts?

[cicoyle]

gentle ping @subash89