java-sdk icon indicating copy to clipboard operation
java-sdk copied to clipboard

[WIP] Add support for TTL and time/interval formats in actor timers/reminders #652

Open Giovds opened this issue 4 years ago • 7 comments

Description

This PR should add the following items:

ActorTimers

  • [x] Add TTL option
  • [x] Allow for repetitions in TTL and Period with ISO-8601 format

ActorReminders

  • [x] Add TTL option
  • [x] Allow for repetitions in TTL and Period with ISO-8601 format

Integration test

  • [ ] Add integration test validating the added features

Issue reference

The issue this PR will close: #652

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation

Giovds avatar Nov 22 '21 23:11 Giovds

CLA assistant check
All CLA requirements met.

ghost avatar Nov 22 '21 23:11 ghost

@Giovds Is there any progress in this?

mukundansundar avatar Jan 05 '22 05:01 mukundansundar

@mukundansundar I haven't had the time to finish this yet, and I will still be unavailable next week. I expect to have time again afterwards. I think what is left is to write integration tests to prove that it works, but I couldn't get them to run them locally yet.

Giovds avatar Jan 05 '22 20:01 Giovds

@Giovds nudge - is there any update on this PR ?

mukundansundar avatar Mar 15 '22 04:03 mukundansundar

Codecov Report

Merging #658 (cf60e2d) into master (eb215fb) will increase coverage by 0.47%. The diff coverage is 97.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #658      +/-   ##
============================================
+ Coverage     77.62%   78.09%   +0.47%     
- Complexity      993     1028      +35     
============================================
  Files            91       92       +1     
  Lines          3128     3196      +68     
  Branches        342      349       +7     
============================================
+ Hits           2428     2496      +68     
- Misses          534      535       +1     
+ Partials        166      165       -1     
Impacted Files Coverage Δ
.../io/dapr/actors/runtime/ActorObjectSerializer.java 83.83% <85.00%> (-0.87%) :arrow_down:
...ain/java/io/dapr/actors/runtime/AbstractActor.java 88.46% <100.00%> (+3.12%) :arrow_up:
...va/io/dapr/actors/runtime/ActorReminderParams.java 100.00% <100.00%> (ø)
.../java/io/dapr/actors/runtime/ActorTimerParams.java 100.00% <100.00%> (ø)
...in/java/io/dapr/actors/runtime/DaprGrpcClient.java 95.60% <100.00%> (+0.09%) :arrow_up:
sdk/src/main/java/io/dapr/utils/DurationUtils.java 98.43% <100.00%> (+2.78%) :arrow_up:
.../src/main/java/io/dapr/utils/RepeatedDuration.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb215fb...cf60e2d. Read the comment docs.

codecov[bot] avatar Mar 15 '22 05:03 codecov[bot]

@Giovds nudge - is there any update on this PR ?

@mukundansundar https://github.com/dapr/java-sdk/issues/652#issuecomment-1039494012

Mainly stuck at creating integration tests and running them locally.

Giovds avatar Mar 15 '22 05:03 Giovds

gentle ping - @Giovds. Please see README as to how to run the tests locally

cicoyle avatar Dec 21 '23 15:12 cicoyle