java-sdk icon indicating copy to clipboard operation
java-sdk copied to clipboard

WIP ISSUE-569: Allow usage of ISO 8601 interval notations

Open TomCools opened this issue 4 years ago • 5 comments

Description

Allow the use of ISO 8601 interval to get feature parity with: https://github.com/dapr/dapr/issues/2513

Issue reference

https://github.com/dapr/java-sdk/issues/569

Please reference the issue this PR will close: #569

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [x] Created/updated tests
  • [ ] Extended the documentation

TomCools avatar Oct 20 '21 11:10 TomCools

Codecov Report

Merging #645 (97f6cbd) into master (91dd2fb) will decrease coverage by 0.08%. The diff coverage is 84.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #645      +/-   ##
============================================
- Coverage     77.25%   77.17%   -0.09%     
- Complexity      946      956      +10     
============================================
  Files            88       88              
  Lines          3012     3054      +42     
  Branches        334      338       +4     
============================================
+ Hits           2327     2357      +30     
- Misses          523      532       +9     
- Partials        162      165       +3     
Impacted Files Coverage Δ
...va/io/dapr/actors/runtime/ActorReminderParams.java 89.65% <72.72%> (-10.35%) :arrow_down:
.../io/dapr/actors/runtime/ActorObjectSerializer.java 83.51% <83.33%> (-1.19%) :arrow_down:
...ain/java/io/dapr/actors/runtime/AbstractActor.java 85.52% <84.93%> (+0.19%) :arrow_up:
sdk/src/main/java/io/dapr/utils/DurationUtils.java 87.32% <88.57%> (-8.33%) :arrow_down:
...in/java/io/dapr/actors/runtime/DaprGrpcClient.java 95.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91dd2fb...97f6cbd. Read the comment docs.

codecov[bot] avatar Jan 05 '22 05:01 codecov[bot]

@TomCools Can you fix conflicts in the PR? And is the PR ready for review?

mukundansundar avatar Apr 08 '22 20:04 mukundansundar

@TomCools mind resolving the conflicts?

cicoyle avatar Dec 21 '23 15:12 cicoyle

gentle ping @TomCools

cicoyle avatar Feb 19 '24 21:02 cicoyle