java-sdk icon indicating copy to clipboard operation
java-sdk copied to clipboard

Increase atMost condition to at most 45 seconds

Open mcruzdev opened this issue 2 weeks ago • 2 comments

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1603

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation

mcruzdev avatar Dec 13 '25 21:12 mcruzdev

@mcruzdev I am wondering why we need to increase to such a high number. Also could you please sign your commit

artur-ciocanu avatar Dec 15 '25 20:12 artur-ciocanu

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 78.67%. Comparing base (d759c53) to head (dbd3983). :warning: Report is 243 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1605      +/-   ##
============================================
+ Coverage     76.91%   78.67%   +1.76%     
- Complexity     1592     1957     +365     
============================================
  Files           145      217      +72     
  Lines          4843     5970    +1127     
  Branches        562      661      +99     
============================================
+ Hits           3725     4697     +972     
- Misses          821      932     +111     
- Partials        297      341      +44     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 17 '25 04:12 codecov[bot]

@mcruzdev I still see issues like these:

 Error:  Errors: 
Error:    DaprPubSubOutboxIT.shouldPublishUsingOutbox:126 » ConditionTimeout Assertion condition defined as a Lambda expression in io.dapr.it.testcontainers.pubsub.outbox.DaprPubSubOutboxIT 
Expecting actual not to be empty within 45 seconds.

artur-ciocanu avatar Dec 17 '25 04:12 artur-ciocanu

+1 I think this needs a bit more investigation here beyond upping the time since it still fails. Appreciate the efforts here 🎉

cicoyle avatar Dec 17 '25 16:12 cicoyle