java-sdk icon indicating copy to clipboard operation
java-sdk copied to clipboard

Setting default props for DaprClient

Open salaboy opened this issue 2 months ago • 3 comments

Description

Setting the default values for DaprClient Spring Boot properties.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature has been discussed prior to implementation.

Please reference the issue this PR will close: #1566

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [x] Created/updated tests
  • [ ] Extended the documentation

salaboy avatar Sep 30 '25 13:09 salaboy

@dapr/maintainers-java-sdk @dapr/approvers-java-sdk without setting these defaults, Spring Boot doesn't know where to find Dapr when running the application. This force the user to set the properties when they shouldn't.

salaboy avatar Sep 30 '25 13:09 salaboy

@salaboy I see that the build steps are timing out could you please check what might be the issue.

Thank you!

artur-ciocanu avatar Oct 19 '25 03:10 artur-ciocanu

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 78.62%. Comparing base (d759c53) to head (33f5e0f). :warning: Report is 243 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1567      +/-   ##
============================================
+ Coverage     76.91%   78.62%   +1.70%     
- Complexity     1592     1952     +360     
============================================
  Files           145      217      +72     
  Lines          4843     5974    +1131     
  Branches        562      661      +99     
============================================
+ Hits           3725     4697     +972     
- Misses          821      932     +111     
- Partials        297      345      +48     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 17 '25 04:12 codecov[bot]

@salaboy I think this PR needs more investigation. The build timeouts, it seems that default values are conflicting with other overrides and tests try to connect to the wrong ports and build times out.

artur-ciocanu avatar Dec 18 '25 15:12 artur-ciocanu