dapr
Add actor state TTL support.
Description
Add actor state TTL support.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #849
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [ ] Code compiles correctly
- [ ] Created/updated tests
- [ ] Extended the documentation
@artursouza looks great!
I have a more general design question related to ActorState. ActorState uses a generic type, however in ActorStateManager it is used without generic type. I am wondering if we should try to enforce generic type usage across other classes like: AbstractActor, StateChangeMetadata, ActorStateOperation, etc to ensure a stronger type safety.
What are your thoughts?
Let me give it a try. These are not exposed to the user and are for internal use only. There might be a reason I did not propagate the generic type everywhere, but I don't remember now. Again, let me revisit this.
@artursouza looks great! I have a more general design question related to ActorState. ActorState uses a generic type, however in ActorStateManager it is used without generic type. I am wondering if we should try to enforce generic type usage across other classes like: AbstractActor, StateChangeMetadata, ActorStateOperation, etc to ensure a stronger type safety. What are your thoughts?
Let me give it a try. These are not exposed to the user and are for internal use only. There might be a reason I did not propagate the generic type everywhere, but I don't remember now. Again, let me revisit this.
See my reply. This is not needed because it is used for serialization and does not interface with the user's API.
@artursouza could you please check the compilation failures for SB 3.2 and SB 3.3, once those are resolved. I think we are good to merge the PR.
Thank you!
@artursouza if you'll have some time could you please check why the tests are failing. I have tried to fix the compilation issues, however I am not sure why the IT is failing.
Thank you!
@cicoyle it might be good if you take this issue, as you were involved.. IMHO the best way to proceed is to create a new PR using the changes from this PR, so we have no DCO issues and then make sure that the tests are green.
