go-sdk icon indicating copy to clipboard operation
go-sdk copied to clipboard

Bidirectional Subscriptions

Open JoshVanL opened this issue 1 year ago • 1 comments

Adds support for bidirectional subscriptions to PubSubs. Adds two methods for subscribing- one using a callback and one using an imperative approach. Both giving support to different programming styles or use cases.

Adds example with tests.

Requires daprd built from https://github.com/dapr/dapr/pull/7770

JoshVanL avatar Jun 19 '24 15:06 JoshVanL

Codecov Report

Attention: Patch coverage is 2.58621% with 113 lines in your changes missing coverage. Please review.

Project coverage is 62.05%. Comparing base (27248ba) to head (32b4f4b). Report is 18 commits behind head on main.

Files Patch % Lines
client/subscribe.go 0.00% 113 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   58.04%   62.05%   +4.00%     
==========================================
  Files          55       53       -2     
  Lines        3568     3352     -216     
==========================================
+ Hits         2071     2080       +9     
+ Misses       1375     1151     -224     
+ Partials      122      121       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 19 '24 15:06 codecov[bot]

the validation step is failing

yaron2 avatar Jul 11 '24 14:07 yaron2

the validation step is failing

It fails as the validation is running the latest version of Dapr rather than the RC.

I've validated with RC2 and it's smooth as butter 🙂 we could set the validation workflow to 1.14.0-rc.2 on the release branch if that helps push this through.

mikeee avatar Jul 11 '24 14:07 mikeee

Can't argue with "smooth as butter" :)

yaron2 avatar Jul 11 '24 14:07 yaron2

@holopin-bot @JoshVanL Thanks Josh!

marcduiker avatar Aug 15 '24 13:08 marcduiker

Congratulations @JoshVanL, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvb8tyf10350cmgajs8h4lq

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

holopin-bot[bot] avatar Aug 15 '24 13:08 holopin-bot[bot]