go-sdk icon indicating copy to clipboard operation
go-sdk copied to clipboard

make workflow client struct public

Open famarting opened this issue 1 year ago • 1 comments

Description

Make workflow client struct public, so it can be referenced and typed and passed as a variable in other applications.

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation

famarting avatar Jun 19 '24 10:06 famarting

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.04%. Comparing base (27248ba) to head (4c7f25d). Report is 11 commits behind head on main.

Files Patch % Lines
workflow/client.go 84.61% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   58.04%   58.04%           
=======================================
  Files          55       55           
  Lines        3568     3568           
=======================================
  Hits         2071     2071           
  Misses       1375     1375           
  Partials      122      122           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 19 '24 10:06 codecov[bot]

I was just trying to figure out why it wasnt public and then this PR popped up :)

ryanwinter avatar Jul 17 '24 17:07 ryanwinter

@holopin-bot @famarting Thank you Fabian!

marcduiker avatar Aug 15 '24 13:08 marcduiker

Congratulations @famarting, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvb807m65250cl0nqqsesax

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

holopin-bot[bot] avatar Aug 15 '24 13:08 holopin-bot[bot]