go-sdk icon indicating copy to clipboard operation
go-sdk copied to clipboard

tests: state_manger_test.go

Open sadath-12 opened this issue 1 year ago • 5 comments

Covers test cases for actor/state/state_manager.go

sadath-12 avatar Dec 16 '23 07:12 sadath-12

Is this a WIP?

Nope its done . Any further suggestions ?

sadath-12 avatar Dec 23 '23 12:12 sadath-12

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (04f7b59) 70.08% compared to head (3eba237) 70.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files          35       35           
  Lines        2841     2841           
=======================================
  Hits         1991     1991           
  Misses        738      738           
  Partials      112      112           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 27 '23 06:12 codecov[bot]

Is this a WIP?

Nope its done . Any further suggestions ?

Apologies, I have a bad habit of reviewing when it's late - I'm not sure if I'm reading this correctly but I don't think this PR implements any testing as intended. You're essentially declaring a mock, telling it what to expect (and return) and then giving it what it expects. There is nothing being passed back to the test runtime either.

mikeee avatar Jan 06 '24 23:01 mikeee

Then I think we should either correct or implement the mock server properly then we can extend more tests as this pr was just meant to add some minimal tests if we see the issue description also other tests related to statemanager in this repo are not doing anything

sadath-12 avatar Jan 07 '24 06:01 sadath-12

I'm not sure what you mean, if I'm reading the contents of this PR correctly - no tests are added.

What other tests are you referring to?

mikeee avatar Jan 07 '24 12:01 mikeee