go-sdk icon indicating copy to clipboard operation
go-sdk copied to clipboard

test: we should add tests for the stateManagerCtx

Open sicoyle opened this issue 2 years ago • 11 comments

Is your feature request related to a problem? Please describe. https://github.com/dapr/go-sdk/blob/main/actor/state/state_manager.go is the only file in the state directory without tests. We should add tests to improve test coverage here.

Describe the solution you'd like We need a state_manager_test.go file added testing the functionality of the stateManagerCtx.

Additional context You can refer to the other test files in the state directory for inspiration and guidance to setup the tests for the state_manager_test.go.

sicoyle avatar Sep 14 '23 00:09 sicoyle

/assign

pieramarchesini avatar Sep 22 '23 21:09 pieramarchesini

adding links here from the chat :)

https://github.com/dapr/go-sdk/blob/e16e0350a52349b5a05138edc0b58e3be78ee753/service/http/health_check_test.go

https://github.com/dapr/go-sdk/blob/e16e0350a52349b5a05138edc0b58e3be78ee753/client/client_test.go#L136

Thank you for helping us improve the go sdk @pieramarchesini during the Grace Hopper Conference open source day event! 🙌

sicoyle avatar Sep 22 '23 22:09 sicoyle

/assign

sadath-12 avatar Dec 14 '23 19:12 sadath-12

⚠️ Unable to assign issue

github-actions[bot] avatar Dec 14 '23 19:12 github-actions[bot]

@pieramarchesini @sadath-12 Heyo, are you both still working on adding some tests?

mikeee avatar Feb 20 '24 15:02 mikeee

Hi @mikeee, Is it okay if I take this one?

KentHsu avatar Apr 30 '24 16:04 KentHsu

@KentHsu - Absolutely, thank you for picking this up!

mikeee avatar Apr 30 '24 16:04 mikeee

/assign

KentHsu avatar Apr 30 '24 17:04 KentHsu

⚠️ Unable to assign issue

github-actions[bot] avatar Apr 30 '24 17:04 github-actions[bot]

/assign

You're already assigned, it's all good 👍

mikeee avatar Apr 30 '24 22:04 mikeee

/assign

You're already assigned, it's all good 👍

Didn't notice I was assigned when I typed it 😅 I created a PR for this issue. Please help to review it and let me know if I'm doing it correctly. Thank you!

KentHsu avatar May 01 '24 13:05 KentHsu