go-sdk
go-sdk copied to clipboard
If an error is returned from TopicEventHandler dapr logs unknown error and message is always retried
Describe the bug If an error is returned from TopicEventHandler dapr logs unknown error and message is always retried
To Reproduce
If a create a TopicEventHandler like this
daprService.AddTopicEventHandler(sub, func(ctx context.Context, event *common.TopicEvent) (retry bool, err error) {
return false, errors.New("error")
})
I see the following error in the dapr logs:
time="2022-04-13T15:49:04.400032825Z" level=error msg="Failed processing MQTT message: topic/1018: error returned from app while processing pub/sub event fc3644c4-c546-4dc8-8b14-616fbb259eb0: rpc error: code = Unknown desc = error" app_id=app instance=c01e7d8695fb scope=dapr.contrib type=log ver=1.7.0
Expected behavior I should see the following warning in the log:
DROP status returned from app while processing pub/sub event
see: https://github.com/dapr/go-sdk/blob/f0e09312fa642059efe4890d790930e8fe14d1cb/service/grpc/topic.go#L146-L153 https://github.com/dapr/dapr/blob/aa6a9092e67bf50ca921a4f443e00e9afa468b04/pkg/runtime/runtime.go#L1710-L1742