dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard

Proposal: Change loglevel to Warning for duplicate priorities in pubsub topic subscriptions

Open arnoldpistorius opened this issue 2 years ago • 3 comments

I have multiple TopicAttributes on the same topic with different filters. The priority of the filters doesn't matter, because they don't overlap. Without a priority on the attribute, the SDK will log the error below. In my opinion this should be warning instead of an error, because:

  • The application continues execution and is functioning properly
  • Monitoring tools will pick up the false-positive error

https://github.com/dapr/dotnet-sdk/blob/e6ded69ca440e6767e96e0c128cbb920f1ee4070/src/Dapr.AspNetCore/DaprEndpointRouteBuilderExtensions.cs#L126

Let me know what you think, I can submit a PR if you want.

arnoldpistorius avatar Dec 06 '22 10:12 arnoldpistorius