dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard

Proposal: Change loglevel to Warning for duplicate priorities in pubsub topic subscriptions

Open arnoldpistorius opened this issue 3 years ago • 3 comments

I have multiple TopicAttributes on the same topic with different filters. The priority of the filters doesn't matter, because they don't overlap. Without a priority on the attribute, the SDK will log the error below. In my opinion this should be warning instead of an error, because:

  • The application continues execution and is functioning properly
  • Monitoring tools will pick up the false-positive error

https://github.com/dapr/dotnet-sdk/blob/e6ded69ca440e6767e96e0c128cbb920f1ee4070/src/Dapr.AspNetCore/DaprEndpointRouteBuilderExtensions.cs#L126

Let me know what you think, I can submit a PR if you want.

arnoldpistorius avatar Dec 06 '22 10:12 arnoldpistorius

Do we have to explicitly assign priorities even in scenarios where that isn't relevant?

Yeg-A avatar Mar 01 '24 14:03 Yeg-A

I'm seeing the same with the .Net SDK and don't really understand the intent of priorities as it seems required and necessarily unique which is odd.

BC89 avatar Jul 23 '24 14:07 BC89

Seems like an easy fix in that it's simply not factoring in matches into whether there are duplicates and looking only at component name, route name and priority to make that determination. Adding e.Match to the grouping here would limit showing the error only to those routes that share the same priority and match and thus overlap.

WhitWaldo avatar Sep 18 '24 14:09 WhitWaldo